Hide view writeup button when no writeup exists #1615
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Note: Defining an analogous check for handouts is harder because the config file might override the default handout behavior
Also note:
flash.now
is necessary because we are rendering directly rather than redirecting (as otherwise the flash would persist for an additional page load). I have updated handout's code to useflash.now
, but it appears thatflash
works too because the route is defined in a different file and that somehow makes a difference.Motivation and Context
Currently, the view writeup button is visible to students even if no writeup exists. Furthermore, the error text is unnecessarily large.
How Has This Been Tested?
Before
Error Text
Button visible
After
Error Flash
Button not visible
Types of changes
Checklist:
overcommit --install && overcommit --sign
to use pre-commit hook for linting