Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes falsy key value for batch get. #379

Merged
merged 1 commit into from
Jul 9, 2018
Merged

Fixes falsy key value for batch get. #379

merged 1 commit into from
Jul 9, 2018

Conversation

haolinj
Copy link
Contributor

@haolinj haolinj commented Jul 9, 2018

Related issue: #378

@coveralls
Copy link

coveralls commented Jul 9, 2018 •
edited
Loading

Pull Request Test Coverage Report for Build 577

  • 2 of 2 (100.0%) changed or added relevant lines in 1 file are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.09%) to 83.971%
Files with Coverage Reduction New Missed Lines %
lib/Table.js 2 77.05%
Totals Coverage Status
Change from base Build 576: -0.09%
Covered Lines: 1844
Relevant Lines: 2124
💛 - Coveralls

fishcharlie
fishcharlie approved these changes Jul 9, 2018
View reviewed changes
Copy link
Member

@fishcharlie fishcharlie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fishcharlie fishcharlie added this to the v1.0 milestone Jul 9, 2018
@fishcharlie fishcharlie mentioned this pull request Jul 9, 2018
Merged
@fishcharlie fishcharlie merged commit c3c2b9e into dynamoose:master Jul 9, 2018
@fishcharlie
Copy link
Member

Thanks for this @haolinj. We will get it released with version 1.0. You can follow the v1.0 progress at PR #365. We have one more PR to finish up before releasing. Thanks again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fishcharlie fishcharlie fishcharlie approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v1.0
Development

Successfully merging this pull request may close these issues.
3 participants
@haolinj @coveralls @fishcharlie