reverting out overzealo (#168)

us trace logging
automerge · May 7, 2024 · 212c711 · 212c711
1 parent c19ba09
commit 212c711
Show file tree

Hide file tree

Showing 2 changed files with 34 additions and 38 deletions.
diff --git a/Sources/Automerge/BoundTypes/AutomergeText.swift b/Sources/Automerge/BoundTypes/AutomergeText.swift
@@ -395,22 +395,23 @@ import os
 
 extension AutomergeText: ObservableObject {
     fileprivate func sendObjectWillChange() {
-        #if canImport(os)
-        if #available(macOS 11, iOS 14, *) {
-            let logger = Logger(subsystem: "Automerge", category: "AutomergeText")
-            logger.trace("\(self.debugDescription) sending ObjectWillChange")
-            let callStacks = Thread.callStackSymbols
-            if callStacks.count > 5 {
-                for callStackFrame in callStacks[0 ... 5] {
-                    logger.trace(" - \(callStackFrame)")
-                }
-            } else {
-                for callStackFrame in callStacks {
-                    logger.trace(" - \(callStackFrame)")
-                }
-            }
-        }
-        #endif
+// DEBUGGING / DIAGNOSTICS CODE to show where object changes are being initiated
+//        #if canImport(os)
+//        if #available(macOS 11, iOS 14, *) {
+//            let logger = Logger(subsystem: "Automerge", category: "AutomergeText")
+//            logger.trace("\(self.debugDescription) sending ObjectWillChange")
+//            let callStacks = Thread.callStackSymbols
+//            if callStacks.count > 5 {
+//                for callStackFrame in callStacks[0 ... 5] {
+//                    logger.trace(" - \(callStackFrame)")
+//                }
+//            } else {
+//                for callStackFrame in callStacks {
+//                    logger.trace(" - \(callStackFrame)")
+//                }
+//            }
+//        }
+//        #endif
         objectWillChange.send()
     }
 }

diff --git a/Sources/Automerge/Document.swift b/Sources/Automerge/Document.swift
@@ -1055,28 +1055,23 @@ import OSLog
 
 extension Document: ObservableObject {
     fileprivate func sendObjectWillChange() {
-        #if canImport(os)
-        if #available(macOS 11, iOS 14, *) {
-            let logger = Logger(subsystem: "Automerge", category: "AutomergeText")
-
-            logger.trace("Document \(String(describing: self)) sending ObjectWillChange")
-            // concurrency violation
-//            let headsString = self.heads().map { ch in
-//                ch.debugDescription
-//            }.joined(separator: ".")
-//            logger.trace("heads: \(headsString)")
-            let callStacks = Thread.callStackSymbols
-            if callStacks.count > 5 {
-                for callStackFrame in callStacks[0 ... 5] {
-                    logger.trace(" - \(callStackFrame)")
-                }
-            } else {
-                for callStackFrame in callStacks {
-                    logger.trace(" - \(callStackFrame)")
-                }
-            }
-        }
-        #endif
+// DEBUGGING / DIAGNOSTICS CODE to show where object changes are being initiated
+//        #if canImport(os)
+//        if #available(macOS 11, iOS 14, *) {
+//            let logger = Logger(subsystem: "Automerge", category: "AutomergeText")
+//            logger.trace("Document \(String(describing: self)) sending ObjectWillChange")
+//            let callStacks = Thread.callStackSymbols
+//            if callStacks.count > 5 {
+//                for callStackFrame in callStacks[0 ... 5] {
+//                    logger.trace(" - \(callStackFrame)")
+//                }
+//            } else {
+//                for callStackFrame in callStacks {
+//                    logger.trace(" - \(callStackFrame)")
+//                }
+//            }
+//        }
+//        #endif
         objectWillChange.send()
     }
 }