Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

macOS: Tray icon related issues & more #183

Closed
abhi3700 opened this issue Apr 26, 2024 · 5 comments
Closed

macOS: Tray icon related issues & more #183

abhi3700 opened this issue Apr 26, 2024 · 5 comments
Labels
macOS macOS-specific

Comments

@abhi3700
Copy link

Background

This issue is observed on macOS using the space-acres version that has this PR #172 merged.

Issues

There are 3 main issues observed:

  1. The tray looks like this on macOS with a different name - "TEST BUTTON":
image

I don't know where this name is defined 🤔 . Is it in gtk library or somewhere else as I didn't find in space-acres's codebase.

  1. I noticed the tray icon goes away when switched to another application. As you can see here in image below that there is no "TEST BUTTON" as tray icon when I switched to browser.
image

Sometimes the tray icon remains to be seen as I navigate through different apps, but browser. Not sure why this happens particularly in case of browser (may be chromium-based) app, Visual Studio Code (sometimes).
Sharing a clip to show this issue:
https://github.com/subspace/space-acres/assets/16472948/0a31b3a7-81b1-4632-9cfc-2b9e94a8ced9

  1. When clicked on this icon as shown in the image below, there are some error logs observed in CLI:
image

Please watch this clip to view the issues:
https://github.com/subspace/space-acres/assets/16472948/0437e78b-d37e-42a0-b4a1-bf0c7a031344

@abhi3700 abhi3700 added the macOS macOS-specific label Apr 26, 2024
@hunjixin
Copy link
Contributor

@abhi3700
the TEST BUTTON string define here https://github.com/sidit77/betrayer/blob/1dbe481a0b9512b3357e3a2ea9cb5ff6edac3b89/src/platform/macos/mod.rs#L59. betray have some test code for macos. but I think the majority of the work is concentrated in this file.

@hunjixin
Copy link
Contributor

for question 2 , I guess the reason is simply that there wasn't enough space in taskbar.

@abhi3700
Copy link
Author

https://github.com/sidit77/betrayer/blob/1dbe481a0b9512b3357e3a2ea9cb5ff6edac3b89/src/platform/macos/mod.rs#L59

Okay! thanks for sharing the crate responsible for this.
Based on this, we can then add a task to somehow change "TEST BUTTON" to "Space Acres" or some icon would be even nicer.

I might take this up next as I am using macOS.

  • Change "TEST BUTTON" to "Space Acres" or add some icon instead (to save space).

@nazar-pc
Copy link
Member

Will likely be solved by #222

@nazar-pc
Copy link
Member

Closing since we have removed old tray icon and it will be fixed once new implementation (likely from #288) lands.

@github-project-automation github-project-automation bot moved this to Complete in Space Acres Aug 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
macOS macOS-specific
Projects
Status: Complete
Development

No branches or pull requests

3 participants