Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Consensus blocks instead of Domain blocks to confirm Domain blocks from Challenge period #2289

Closed
vedhavyas opened this issue Dec 5, 2023 · 2 comments
Assignees
Labels
execution Subspace execution mainnet-beta

Comments

@vedhavyas
Copy link
Contributor

Currently, we use domain blocks to confirm the parent domain block from the challenge period. When a domain is stalled for some reason, parent domain blocks will never be confirmed. This also has another issue where challenge period for each domain may vary depending the frequency of the domain blocks.
Using Consensus block to confirm domain blocks would ensure confirmation even when there are no domain blocks to be confirmed. This also enables use to not produce an empty bundle to push the parent domain block out of challenge period.

There are some further discussions noted on notion here - https://www.notion.so/subspacelabs/Concerns-on-Challenge-period-deriving-from-Consensus-blocks-6296267d6dc243a4a72023c3148a9c76
cc: @jfrank-summit

@dariolina
Copy link
Member

Just to note, the StakeWithdrawalLockingPeriod and withdrawal process should be updated accordingly.

@dariolina
Copy link
Member

Based on concerns described here https://www.notion.so/subspacelabs/Attacking-the-domain-challenge-period-f651dd289405491fba42dbceb33142d9?pvs=4 we have decided not to move forward with this and keep the domain challenge period in domain blocks.

@dariolina dariolina closed this as not planned Won't fix, can't repro, duplicate, stale May 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
execution Subspace execution mainnet-beta
Projects
Status: Done
Development

No branches or pull requests

4 participants