-
Notifications
You must be signed in to change notification settings - Fork 273
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Plugin should not override ALE settings unless requested #569
Comments
This plugin never override ALE settings as far as I remember. It defines its own sign types at LanguageClient-neovim/src/languageclient.rs Line 234 in 232774c
With definitions from LanguageClient-neovim/doc/LanguageClient.txt Lines 79 to 109 in 232774c
Since you're disable sign drawing from this plugin, there shouldn't be any sign instances of this defined type shown anyway. |
You should be able to work around this with: let g:LanguageClient_diagnosticsEnable=0 assuming you want to use ALE for linting instead. |
This depends on the color scheme that is used.
Without this plugin it links to Error
One solution is to just define the highlight groups
|
Is it possible to output LanguageClient-neovim errors through ALE? Edit: I think it's not, so I opened #800 to track that. That should fix this issue too, as diagnostics would be unified. |
As of #1144 LCN does no longer use ale's highlight groups, it instead defines it's own groups and uses that as a default, so this shouldn't be a problem anymore. If the problem persists thought, feel free to re-open. |
:checkhealth LanguageClient
? YesDescribe the bug
I have my own very specific settings for how ALE displays symbols in the sign column but once I enable LanguageClient, it is partially overridden by your defaults. This plugin should have an option to disable such behavior.
Environment
nvim --version
orvim --version
):git rev-parse --short HEAD
):605c07e
bin/languageclient --version
):0.1.110
reproduce the issue. Refer to an example [here][min-vimrc.vim]):
rls-preview 0.128.0-stable (7d0bc55 2018-06-07)
To Reproduce
Steps to reproduce the behavior:
cargo
projectCurrent behavior
With LanguageClient enabled, ALE settings for the sign column is partially overridden.
Expected behavior
I expect that my ALE settings to be left untouched unless I specifically asked for it.
Screenshots
With LanguageClient disabled:
With LanguageClient enabled:
The text was updated successfully, but these errors were encountered: