Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ALE-like underscore/wavy for diagnostics #852

Closed
Huxpro opened this issue Jul 12, 2019 · 1 comment
Closed

ALE-like underscore/wavy for diagnostics #852

Huxpro opened this issue Jul 12, 2019 · 1 comment

Comments

@Huxpro
Copy link

Huxpro commented Jul 12, 2019

Is your feature request related to a problem? Please describe.

Currently, if ALE is not running along with this extension. The diagnostics from LSP only display sign in column and virtual texts but ignore the Range.

Screen Shot 2019-07-12 at 1 12 06 PM

Describe the solution you'd like

Have native supports on that.
Btw, it seems like ALE itself is intended to evolve into a full-fledged language clients as well.
Do we want to depend on it?

Alternative

As CoC.vim? Show diagnostics via ALE.

Additional context

I am confusing by the fact that Updates - Diagnostics does show the underline. Does it come from ALE or this extension?

@autozimu
Copy link
Owner

There is no intention for this plugin to depend on other plugins regarding LSP as it is positioned to be the lowest level to talk to language servers.

The underline of GIF showing in Updates is indeed displayed by this plugin.

The styles for highlighting ranges of text are defined as

Default: >
{
1: {
"name": "Error",
"texthl": "ALEError",
"signText": "✖",
"signTexthl": "ALEErrorSign",
"virtualTexthl": "Error",
},
2: {
"name": "Warning",
"texthl": "ALEWarning",
"signText": "⚠",
"signTexthl": "ALEWarningSign",
"virtualTexthl": "Todo",
},
3: {
"name": "Information",
"texthl": "ALEInfo",
"signText": "ℹ",
"signTexthl": "ALEInfoSign",
"virtualTexthl": "Todo",
},
4: {
"name": "Hint",
"texthl": "ALEInfo",
"signText": "➤",
"signTexthl": "ALEInfoSign",
"virtualTexthl": "Todo",
},
}
. More specifically, it is texthl. You might want to make sure your theme display those highlight groups prominently or customize this setting to different highlight groups.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants