From e11dcee97095ded1cbeea93794f2860f3639c0e1 Mon Sep 17 00:00:00 2001
From: Kasia Kucharczyk <2536609+kkucharc@users.noreply.github.com>
Date: Mon, 21 Sep 2020 21:26:17 +0200
Subject: [PATCH] fix: changed disabled rules in datasets module (#10979)

* Updated `put` method in `datasets/api.py`:
- changed return statements in put method
- removed disabled pylint rule too-many-return-statements
- removed disabled pylint rule arguments-differ since arguments match

* Removed disabled pylint rule arguments-differ in `delete()` method since arguments match
---
 superset/datasets/api.py | 17 ++++++++---------
 1 file changed, 8 insertions(+), 9 deletions(-)

diff --git a/superset/datasets/api.py b/superset/datasets/api.py
index 93c2b92496e65..40b8c5edec0a2 100644
--- a/superset/datasets/api.py
+++ b/superset/datasets/api.py
@@ -216,9 +216,7 @@ def post(self) -> Response:
     @protect()
     @safe
     @statsd_metrics
-    def put(  # pylint: disable=too-many-return-statements, arguments-differ
-        self, pk: int
-    ) -> Response:
+    def put(self, pk: int) -> Response:
         """Changes a Dataset
         ---
         put:
@@ -270,24 +268,25 @@ def put(  # pylint: disable=too-many-return-statements, arguments-differ
             return self.response_400(message=error.messages)
         try:
             changed_model = UpdateDatasetCommand(g.user, pk, item).run()
-            return self.response(200, id=changed_model.id, result=item)
+            response = self.response(200, id=changed_model.id, result=item)
         except DatasetNotFoundError:
-            return self.response_404()
+            response = self.response_404()
         except DatasetForbiddenError:
-            return self.response_403()
+            response = self.response_403()
         except DatasetInvalidError as ex:
-            return self.response_422(message=ex.normalized_messages())
+            response = self.response_422(message=ex.normalized_messages())
         except DatasetUpdateFailedError as ex:
             logger.error(
                 "Error updating model %s: %s", self.__class__.__name__, str(ex)
             )
-            return self.response_422(message=str(ex))
+            response = self.response_422(message=str(ex))
+        return response
 
     @expose("/<pk>", methods=["DELETE"])
     @protect()
     @safe
     @statsd_metrics
-    def delete(self, pk: int) -> Response:  # pylint: disable=arguments-differ
+    def delete(self, pk: int) -> Response:
         """Deletes a Dataset
         ---
         delete: