-
Notifications
You must be signed in to change notification settings - Fork 662
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
v1.11.8 metric misspelling. #3119
Comments
This wasn't actually completely unintended... There are 3 different types of health checks:
So, the namespace of these metrics are:
To make:
Do you (@mark-liu) think it would make more sense to change the inner names to themselves be labels? Which would result in:
|
@StephenButtolph labels is a nice approach, clean and lines up with prom best practice and allows easy aggregation. |
Describe the bug
In v1.11.8 the metric
avalanche_health_checks_failing
has been misspeltavalanche_health_health_checks_failing
To Reproduce
Just curl for the metric.
Expected behavior
It should be named
avalanche_health_checks_failing
Screenshots
![Untitled](https://private-user-images.githubusercontent.com/924487/339586699-fc3ca332-b794-4b54-b9d2-ce9b81e34472.jpg?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjQ1ODE2MDQsIm5iZiI6MTcyNDU4MTMwNCwicGF0aCI6Ii85MjQ0ODcvMzM5NTg2Njk5LWZjM2NhMzMyLWI3OTQtNGI1NC1iOWQyLWNlOWI4MWUzNDQ3Mi5qcGc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjQwODI1JTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI0MDgyNVQxMDIxNDRaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT1lODc0ZWQ5Y2I2YmIxYTlkNTFlMjE3ZTZhYjViNDc3NDhhYTRiZjBkNWU0ODVjZTc5MDcxMmNhOTVlYjlkZTMxJlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCZhY3Rvcl9pZD0wJmtleV9pZD0wJnJlcG9faWQ9MCJ9.Wj6pnozGqYfw0Wz9PxSsjrmCGYf7ozUTcOKvfEZ-eAU)
Logs
If applicable, please include the relevant logs that indicate a problem and/or the log directory of your node. By default, this can be found at
~/.avalanchego/logs/
.Metrics
If applicable, please include any metrics gathered from your node to assist us in diagnosing the problem.
Operating System
Which OS you used to reveal the bug.
Linux amd64
The text was updated successfully, but these errors were encountered: