From fc2b31a416ecbb77947ca9e90bc3dbadcc8d92c9 Mon Sep 17 00:00:00 2001 From: Maru Newby Date: Mon, 1 Jul 2024 05:07:49 +0200 Subject: [PATCH] [ci] Add actionlint job --- .github/actionlint.yml | 5 +++++ .github/workflows/build-linux-binaries.yml | 8 +++---- .github/workflows/build-macos-release.yml | 8 +++---- .github/workflows/build-public-ami.yml | 8 +++---- .../workflows/build-ubuntu-amd64-release.yml | 8 +++---- .../workflows/build-ubuntu-arm64-release.yml | 8 +++---- .github/workflows/build-win-release.yml | 4 ++-- .github/workflows/ci.yml | 5 ++++- .../workflows/publish_antithesis_images.yml | 4 ++-- .github/workflows/trigger-antithesis-runs.yml | 22 ++++++++++--------- scripts/actionlint.sh | 7 ++++++ 11 files changed, 52 insertions(+), 35 deletions(-) create mode 100644 .github/actionlint.yml create mode 100755 scripts/actionlint.sh diff --git a/.github/actionlint.yml b/.github/actionlint.yml new file mode 100644 index 00000000000..2e6d753c228 --- /dev/null +++ b/.github/actionlint.yml @@ -0,0 +1,5 @@ +self-hosted-runner: + labels: + - custom-arm64-focal + - custom-arm64-jammy + - net-outage-sim diff --git a/.github/workflows/build-linux-binaries.yml b/.github/workflows/build-linux-binaries.yml index 9f5cdfe9747..bcaf374f393 100644 --- a/.github/workflows/build-linux-binaries.yml +++ b/.github/workflows/build-linux-binaries.yml @@ -40,14 +40,14 @@ jobs: if: "${{ github.event.inputs.tag == '' }}" id: get_tag_from_git run: | - echo "TAG=${GITHUB_REF/refs\/tags\//}" >> $GITHUB_ENV + echo "TAG=${GITHUB_REF/refs\/tags\//}" >> "$GITHUB_ENV" shell: bash - name: Try to get tag from workflow dispatch if: "${{ github.event.inputs.tag != '' }}" id: get_tag_from_workflow run: | - echo "TAG=${{ github.event.inputs.tag }}" >> $GITHUB_ENV + echo "TAG=${{ github.event.inputs.tag }}" >> "$GITHUB_ENV" shell: bash - name: Create tgz package structure and upload to S3 @@ -101,14 +101,14 @@ jobs: if: "${{ github.event.inputs.tag == '' }}" id: get_tag_from_git run: | - echo "TAG=${GITHUB_REF/refs\/tags\//}" >> $GITHUB_ENV + echo "TAG=${GITHUB_REF/refs\/tags\//}" >> "$GITHUB_ENV" shell: bash - name: Try to get tag from workflow dispatch if: "${{ github.event.inputs.tag != '' }}" id: get_tag_from_workflow run: | - echo "TAG=${{ github.event.inputs.tag }}" >> $GITHUB_ENV + echo "TAG=${{ github.event.inputs.tag }}" >> "$GITHUB_ENV" shell: bash - name: Create tgz package structure and upload to S3 diff --git a/.github/workflows/build-macos-release.yml b/.github/workflows/build-macos-release.yml index 2a4bfb1c45d..8a7f641ed3f 100644 --- a/.github/workflows/build-macos-release.yml +++ b/.github/workflows/build-macos-release.yml @@ -35,18 +35,18 @@ jobs: if: "${{ github.event.inputs.tag == '' }}" id: get_tag_from_git run: | - echo "TAG=${GITHUB_REF/refs\/tags\//}" >> $GITHUB_ENV + echo "TAG=${GITHUB_REF/refs\/tags\//}" >> "$GITHUB_ENV" shell: bash - name: Try to get tag from workflow dispatch if: "${{ github.event.inputs.tag != '' }}" id: get_tag_from_workflow run: | - echo "TAG=${{ github.event.inputs.tag }}" >> $GITHUB_ENV + echo "TAG=${{ github.event.inputs.tag }}" >> "$GITHUB_ENV" shell: bash - name: Create zip file - run: 7z a avalanchego-macos-${TAG}.zip build/avalanchego + run: 7z a "avalanchego-macos-${TAG}.zip" build/avalanchego env: TAG: ${{ env.TAG }} @@ -63,7 +63,7 @@ jobs: aws-region: us-east-1 - name: Upload file to S3 - run: aws s3 cp avalanchego-macos-${{ env.TAG }}.zip s3://${BUCKET}/macos/ + run: aws s3 cp avalanchego-macos-${{ env.TAG }}.zip "s3://${BUCKET}/macos/" env: BUCKET: ${{ secrets.BUCKET }} diff --git a/.github/workflows/build-public-ami.yml b/.github/workflows/build-public-ami.yml index cc9082ab3e3..314b110865a 100644 --- a/.github/workflows/build-public-ami.yml +++ b/.github/workflows/build-public-ami.yml @@ -27,16 +27,16 @@ jobs: - name: Install aws cli run: | sudo apt update - sudo apt-get -y install python3-boto3=${PYTHON3_BOTO3_VERSION} + sudo apt-get -y install python3-boto3="${PYTHON3_BOTO3_VERSION}" - name: Get the tag id: get_tag run: | if [[ ${{ github.event_name }} == 'push' ]]; then - echo "TAG=${GITHUB_REF/refs\/tags\//}" >> $GITHUB_ENV + echo "TAG=${GITHUB_REF/refs\/tags\//}" >> "$GITHUB_ENV" else - echo "TAG=${{ inputs.tag }}" >> $GITHUB_ENV + echo "TAG=${{ inputs.tag }}" >> "$GITHUB_ENV" fi shell: bash @@ -44,7 +44,7 @@ jobs: run: | if [ "${{ github.event_name }}" == "workflow_dispatch" ]; then echo "Setting SKIP_CREATE_AMI to False" - echo "SKIP_CREATE_AMI=False" >> $GITHUB_ENV + echo "SKIP_CREATE_AMI=False" >> "$GITHUB_ENV" fi - name: Configure AWS credentials diff --git a/.github/workflows/build-ubuntu-amd64-release.yml b/.github/workflows/build-ubuntu-amd64-release.yml index 7c00b56d122..ff26569570c 100644 --- a/.github/workflows/build-ubuntu-amd64-release.yml +++ b/.github/workflows/build-ubuntu-amd64-release.yml @@ -38,14 +38,14 @@ jobs: if: "${{ github.event.inputs.tag == '' }}" id: get_tag_from_git run: | - echo "TAG=${GITHUB_REF/refs\/tags\//}" >> $GITHUB_ENV + echo "TAG=${GITHUB_REF/refs\/tags\//}" >> "$GITHUB_ENV" shell: bash - name: Try to get tag from workflow dispatch if: "${{ github.event.inputs.tag != '' }}" id: get_tag_from_workflow run: | - echo "TAG=${{ github.event.inputs.tag }}" >> $GITHUB_ENV + echo "TAG=${{ github.event.inputs.tag }}" >> "$GITHUB_ENV" shell: bash - name: Create debian package @@ -88,14 +88,14 @@ jobs: if: "${{ github.event.inputs.tag == '' }}" id: get_tag_from_git run: | - echo "TAG=${GITHUB_REF/refs\/tags\//}" >> $GITHUB_ENV + echo "TAG=${GITHUB_REF/refs\/tags\//}" >> "$GITHUB_ENV" shell: bash - name: Try to get tag from workflow dispatch if: "${{ github.event.inputs.tag != '' }}" id: get_tag_from_workflow run: | - echo "TAG=${{ github.event.inputs.tag }}" >> $GITHUB_ENV + echo "TAG=${{ github.event.inputs.tag }}" >> "$GITHUB_ENV" shell: bash - name: Configure AWS credentials diff --git a/.github/workflows/build-ubuntu-arm64-release.yml b/.github/workflows/build-ubuntu-arm64-release.yml index 096137b1a2e..4d8fa841cbd 100644 --- a/.github/workflows/build-ubuntu-arm64-release.yml +++ b/.github/workflows/build-ubuntu-arm64-release.yml @@ -38,14 +38,14 @@ jobs: if: "${{ github.event.inputs.tag == '' }}" id: get_tag_from_git run: | - echo "TAG=${GITHUB_REF/refs\/tags\//}" >> $GITHUB_ENV + echo "TAG=${GITHUB_REF/refs\/tags\//}" >> "$GITHUB_ENV" shell: bash - name: Try to get tag from workflow dispatch if: "${{ github.event.inputs.tag != '' }}" id: get_tag_from_workflow run: | - echo "TAG=${{ github.event.inputs.tag }}" >> $GITHUB_ENV + echo "TAG=${{ github.event.inputs.tag }}" >> "$GITHUB_ENV" shell: bash - name: Create debian package @@ -96,14 +96,14 @@ jobs: if: "${{ github.event.inputs.tag == '' }}" id: get_tag_from_git run: | - echo "TAG=${GITHUB_REF/refs\/tags\//}" >> $GITHUB_ENV + echo "TAG=${GITHUB_REF/refs\/tags\//}" >> "$GITHUB_ENV" shell: bash - name: Try to get tag from workflow dispatch if: "${{ github.event.inputs.tag != '' }}" id: get_tag_from_workflow run: | - echo "TAG=${{ github.event.inputs.tag }}" >> $GITHUB_ENV + echo "TAG=${{ github.event.inputs.tag }}" >> "$GITHUB_ENV" shell: bash - name: Create debian package diff --git a/.github/workflows/build-win-release.yml b/.github/workflows/build-win-release.yml index 9d04e036b7e..15502e00322 100644 --- a/.github/workflows/build-win-release.yml +++ b/.github/workflows/build-win-release.yml @@ -44,14 +44,14 @@ jobs: if: "${{ github.event.inputs.tag == '' }}" id: get_tag_from_git run: | - echo "TAG=${GITHUB_REF/refs\/tags\//}" >> $GITHUB_ENV + echo "TAG=${GITHUB_REF/refs\/tags\//}" >> "$GITHUB_ENV" shell: bash - name: Try to get tag from workflow dispatch if: "${{ github.event.inputs.tag != '' }}" id: get_tag_from_workflow run: | - echo "TAG=${{ github.event.inputs.tag }}" >> $GITHUB_ENV + echo "TAG=${{ github.event.inputs.tag }}" >> "$GITHUB_ENV" shell: bash # Runs a single command using the runners shell diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 7fc80756dae..68ee2585a3b 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -37,7 +37,7 @@ jobs: - name: Set timeout on Windows # Windows UT run slower and need a longer timeout shell: bash if: matrix.os == 'windows-2022' - run: echo "TIMEOUT=240s" >> $GITHUB_ENV + run: echo "TIMEOUT=240s" >> "$GITHUB_ENV" - name: build_test shell: bash run: ./scripts/build_test.sh @@ -213,6 +213,9 @@ jobs: - name: Run shellcheck shell: bash run: scripts/shellcheck.sh + - name: Run actionlint + shell: bash + run: scripts/actionlint.sh buf-lint: name: Protobuf Lint runs-on: ubuntu-latest diff --git a/.github/workflows/publish_antithesis_images.yml b/.github/workflows/publish_antithesis_images.yml index 8363ad73e97..8dc9d426f94 100644 --- a/.github/workflows/publish_antithesis_images.yml +++ b/.github/workflows/publish_antithesis_images.yml @@ -35,12 +35,12 @@ jobs: run: bash -x ./scripts/build_antithesis_images.sh env: IMAGE_PREFIX: ${{ env.REGISTRY }}/${{ env.REPOSITORY }} - TAG: ${{ github.events.inputs.image_tag || 'latest' }} + TAG: ${{ github.event.inputs.image_tag || 'latest' }} TEST_SETUP: avalanchego - name: Build and push images for xsvm test setup run: bash -x ./scripts/build_antithesis_images.sh env: IMAGE_PREFIX: ${{ env.REGISTRY }}/${{ env.REPOSITORY }} - TAG: ${{ github.events.inputs.image_tag || 'latest' }} + TAG: ${{ github.event.inputs.image_tag || 'latest' }} TEST_SETUP: xsvm diff --git a/.github/workflows/trigger-antithesis-runs.yml b/.github/workflows/trigger-antithesis-runs.yml index 0521b0770d7..f893b88da9e 100644 --- a/.github/workflows/trigger-antithesis-runs.yml +++ b/.github/workflows/trigger-antithesis-runs.yml @@ -21,7 +21,8 @@ on: type: string jobs: - Run Antithesis Avalanchego Test Setup: + antithesis_avalanchego: + name: Run Antithesis Avalanchego Test Setup runs-on: ubuntu-latest steps: - uses: antithesishq/antithesis-trigger-action@v0.5 @@ -31,12 +32,13 @@ jobs: username: ${{ secrets.ANTITHESIS_USERNAME }} password: ${{ secrets.ANTITHESIS_PASSWORD }} github_token: ${{ secrets.ANTITHESIS_GH_PAT }} - config_image: antithesis-avalanchego-config@${{ github.events.inputs.image_tag }} - images: antithesis-avalanchego-workload@${{ github.events.inputs.image_tag }};antithesis-avalanchego-node@${{ github.events.inputs.image_tag }} - email_recipients: ${{ github.events.inputs.recipients }} + config_image: antithesis-avalanchego-config@${{ github.event.inputs.image_tag || 'latest' }} + images: antithesis-avalanchego-workload@${{ github.event.inputs.image_tag || 'latest' }};antithesis-avalanchego-node@${{ github.event.inputs.image_tag || 'latest' }} + email_recipients: ${{ github.event.inputs.recipients || secrets.ANTITHESIS_RECIPIENTS }} additional_parameters: |- - custom.duration=${{ github.events.inputs.duration }} - Run Antithesis XSVM Test Setup: + custom.duration=${{ github.event.inputs.duration || '0.5' }} + antithesis_xsvm: + name: Run Antithesis XSVM Test Setup runs-on: ubuntu-latest steps: - uses: antithesishq/antithesis-trigger-action@v0.5 @@ -46,8 +48,8 @@ jobs: username: ${{ secrets.ANTITHESIS_USERNAME }} password: ${{ secrets.ANTITHESIS_PASSWORD }} github_token: ${{ secrets.ANTITHESIS_GH_PAT }} - config_image: antithesis-xsvm-config@${{ github.events.inputs.image_tag }} - images: antithesis-xsvm-workload@${{ github.events.inputs.image_tag }};antithesis-xsvm-node@${{ github.events.inputs.image_tag }} - email_recipients: ${{ github.events.inputs.recipients }} + config_image: antithesis-xsvm-config@${{ github.event.inputs.image_tag || 'latest' }} + images: antithesis-xsvm-workload@${{ github.event.inputs.image_tag || 'latest' }};antithesis-xsvm-node@${{ github.event.inputs.image_tag || 'latest' }} + email_recipients: ${{ github.event.inputs.recipients || secrets.ANTITHESIS_RECIPIENTS }} additional_parameters: |- - custom.duration=${{ github.events.inputs.duration }} + custom.duration=${{ github.event.inputs.duration || '0.5' }} diff --git a/scripts/actionlint.sh b/scripts/actionlint.sh new file mode 100755 index 00000000000..bdc3083e6b6 --- /dev/null +++ b/scripts/actionlint.sh @@ -0,0 +1,7 @@ +#!/usr/bin/env bash + +set -euo pipefail + +go install github.com/rhysd/actionlint/cmd/actionlint@v1.7.1 + +actionlint