Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change Github security scans to develop branch #4466

Closed
mcwhitaker opened this issue May 17, 2021 · 4 comments
Closed

Change Github security scans to develop branch #4466

mcwhitaker opened this issue May 17, 2021 · 4 comments
Assignees

Comments

@mcwhitaker
Copy link
Contributor

Descriptive summary

Security scans against master requires us to recreate the PRs in develop. Moving the security scans to develop will reduce the amount of work that we have to do to deal with the PRs.

Done looks like

Security scans happen in develop.

@joncameron joncameron changed the title Change security scans to develop branch Change Github security scans to develop branch May 20, 2021
@Dananji Dananji self-assigned this May 24, 2021
@Dananji
Copy link
Contributor

Dananji commented May 26, 2021

For Dependabot we have setup the develop branch to be the target-branch in the .dependabot/config.yml file but it still targets the master branch.
I tried @dependabot rebase and @dependabot recreate commands after changing the target branch in a dependabot PR. And it always goes to master.

I found this reported issue on their GitHub. According to this, even when we have setup dependabot configuration for the repo, the security updates act based on GitHub's security updates work. And this is based on the Dependency graph (based on the default branch's manifests), therefore the PRs are made to master branch which is the default branch in our case.

@Dananji
Copy link
Contributor

Dananji commented May 26, 2021

Right now Snyk also works with the default branch of the repo, so the PRs are always made to master.

@Dananji
Copy link
Contributor

Dananji commented May 26, 2021

For both of these, the solution I see for now is changing our default branch to develop from master.

@joncameron joncameron added this to the May 21 - Jun 4 (Sprint 280) milestone Jun 3, 2021
@mcwhitaker
Copy link
Contributor Author

We have decided to keep things as they are. Dananji will work on the PRs in avalon-bundle first to make it slightly easier to work on the PRs in the avalon repo after having done it once.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants