Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Sharepoint Provider to BrowseEverything #5987

Closed
2 tasks done
joncameron opened this issue Aug 13, 2024 · 6 comments
Closed
2 tasks done

Add Sharepoint Provider to BrowseEverything #5987

joncameron opened this issue Aug 13, 2024 · 6 comments
Assignees

Comments

@joncameron
Copy link
Contributor

joncameron commented Aug 13, 2024

Description

Support for Sharepoint as a filesystem provider has not been available in Browse Everything, which Avalon uses currently for navigating local and cloud filesystems. Since Indiana University as well as many others use Sharepoint for file storage, Avalon too should be able to retrieve files from it in the same way we provide support for Google Drive.

A long-term strategy would be moving away from this to a library with broader general support such as Uppy, but there has been some previous work that may still be effective in communicating with Sharepoint—if the existing provider work that already exists (samvera/browse-everything#418) would be able to authenticate, show and retrieve files from Sharepoint storage it might be worthwhile to implement as a way to meet Avalon's short-term needs.

Done Looks Like

  • Evaluation: is this still PR still current?
  • Add to Avalon Browse Everything (merge into a local branch?) and test
@masaball masaball self-assigned this Sep 16, 2024
@masaball
Copy link
Contributor

masaball commented Sep 26, 2024

PR to BrowseEverything fork: avalonmediasystem/browse-everything#2. I think currently Avalon is pointing directly at the v1.4-avalon branch, so should we tag that branch and point Avalon to the tag before merging the PR? Once everything looks good on the browse-everything side, I will create a PR to Avalon.

For testing/implementation we will need to register the application(s) in the Entra admin center to get client credentials and set permissions. The process is pretty straightforward but maybe it would be a good short swarm topic for me to walk through it with everyone, @elynema? I can also do an initial draft of documentation for the wiki for if/when we get this implemented in a release.

@elynema
Copy link
Contributor

elynema commented Sep 27, 2024

@masaball I can put this on the agenda for Swarm next week.

@Dananji
Copy link
Contributor

Dananji commented Sep 30, 2024

For the SharePoint integration work in Uppy, we needed to submit a request to UITS Tier 2 Support (sct2@iu.edu) to request approval for the Microsoft app we create as part of the integration.
For the request we submitted for the SharePoint integration with Uppy we received the following response from UITS;

SharePoint integration might be possible, but any sort of integration requiring M365 admin permissions requires going through SSSP more often than not.
I looked through our instance for Uppy, and found an uppy-sharepoint-test app that only requires user-grantable Microsoft Graph permissions and hasn't asked for admin-restricted permissions. If Uppy needs admin permissions, please take screenshots so the admins can see what permissions need to be granted.

I think in the initial request we need submit evidence that the app we are creating in the Microsoft admin dashboard, which we use with BrowseEverything to access SharePoint doesn't have permission to list the sites the user has access from our end of the app.

At some point we needed to submit a SSSP request since the initial request to UITS Tier 2 Support was not able to provide the permissions we needed for the integration.

@elynema
Copy link
Contributor

elynema commented Oct 3, 2024

Mason has a PR to our fork of browse-everything. Need to discuss with Chris - it was working for Mason on his local machine; how do we want to bring it into Avalon for testing before starting on expanding to Sharepoint sites?

Would be good to QA this before moving on to try to add Sharepoint sites.

@elynema
Copy link
Contributor

elynema commented Oct 8, 2024

For the Avalon side of the work, Mason will put up a branch or draft PR for calling the new Browse Everything code into Avalon.

@elynema
Copy link
Contributor

elynema commented Oct 31, 2024

I tested this in Chrome and Safari, both in a browser that was already logged into Microsoft and one where I needed to go through the login process. It seemed to work amazingly seamlessly in both environments. I was able to browse folders and upload both an audio and a video item. The file / section label was populated with the file name from OneDrive.

This looks like it's working well to me!

@joncameron @masaball Currently, the order of options in DropBox is Google Drive, AWS, Sharepoint. Is it code in BrowseEverything or Avalon to re-order that? I'm guessing we might want to list Sharepoint first, but not sure.

@elynema elynema closed this as completed Nov 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants