From 0c81fbc0cb2d9e601ee500acee8672a8fa670a8b Mon Sep 17 00:00:00 2001 From: Bahugunajii Date: Wed, 10 Jul 2024 17:05:08 +0530 Subject: [PATCH 1/2] show subject id instead of subject --- lib/dbservice_web/views/teacher_view.ex | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/lib/dbservice_web/views/teacher_view.ex b/lib/dbservice_web/views/teacher_view.ex index 31c0ff46..bf8a7b03 100644 --- a/lib/dbservice_web/views/teacher_view.ex +++ b/lib/dbservice_web/views/teacher_view.ex @@ -2,7 +2,6 @@ defmodule DbserviceWeb.TeacherView do use DbserviceWeb, :view alias DbserviceWeb.TeacherView alias DbserviceWeb.UserView - alias DbserviceWeb.SubjectView alias Dbservice.Repo def render("index.json", %{teacher: teacher}) do @@ -24,7 +23,7 @@ defmodule DbserviceWeb.TeacherView do id: teacher.id, designation: teacher.designation, teacher_id: teacher.teacher_id, - subject: render_one(teacher.subject, SubjectView, "subject.json"), + subject_id: teacher.subject_id, user: render_one(teacher.user, UserView, "user.json") } end @@ -34,7 +33,7 @@ defmodule DbserviceWeb.TeacherView do id: teacher.id, designation: teacher.designation, teacher_id: teacher.teacher_id, - subject: render_one(teacher.subject, SubjectView, "subject.json"), + subject_id: teacher.subject_id, user: render_one(teacher.user, UserView, "user.json") } end From dee01f8b836aa6128e5e91c55c9ef504ca7c2bb9 Mon Sep 17 00:00:00 2001 From: Bahugunajii Date: Wed, 10 Jul 2024 17:13:29 +0530 Subject: [PATCH 2/2] fixed update function --- lib/dbservice_web/controllers/teacher_controller.ex | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/lib/dbservice_web/controllers/teacher_controller.ex b/lib/dbservice_web/controllers/teacher_controller.ex index 9ed0413a..fe687865 100644 --- a/lib/dbservice_web/controllers/teacher_controller.ex +++ b/lib/dbservice_web/controllers/teacher_controller.ex @@ -154,7 +154,10 @@ defmodule DbserviceWeb.TeacherController do end defp update_existing_teacher_with_user(conn, existing_teacher, params) do - with {:ok, %Teacher{} = teacher} <- Users.update_teacher_with_user(existing_teacher, params) do + user = Users.get_user!(existing_teacher.user_id) + + with {:ok, %Teacher{} = teacher} <- + Users.update_teacher_with_user(existing_teacher, user, params) do conn |> put_status(:ok) |> render("show.json", teacher: teacher)