Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Name conflict with fileinfo from Leptonica #70

Closed
c-mauderer opened this issue Dec 25, 2017 · 7 comments
Closed

Name conflict with fileinfo from Leptonica #70

c-mauderer opened this issue Dec 25, 2017 · 7 comments

Comments

@c-mauderer
Copy link

I have a (minor) problem: On my system I have leptonica installed (the image processing library). I tried to install retdec and had the problem that both provide a tool called /usr/bin/fileinfo.

It's not really a big problem because I can just use some prefix or temporary rename the tools. But for a number of Linux distribution that could be a problem if they want to provide retdec as a package.

A possible solution would be some other name like retdecfileinfo.

@s3rvac s3rvac changed the title Name conflict with leptonica fileinfo. Name conflict with fileinfo from Leptonica Dec 26, 2017
@s3rvac
Copy link
Member

s3rvac commented Dec 26, 2017

Hi. Thank you for the report. Currently, it is not recommended to install RetDec directly into your system (e.g. /usr). One reason for this is that there may be name conflicts. We recommend installing RetDec into a dedicated directory in your home directory, and then appropriately adding e.g. $HOME/projects/retdec/bin into your PATH.

Nevertheless, it would indeed be better if our tools were named more uniquely. We will address this when modifying the build system so that RetDec supports system-wide installation.

@c-mauderer
Copy link
Author

Hello @s3rvac, thanks for the response. Great to hear that you will try to get some more unique naming in the future. Currently I have a system wide installation because I use an AUR package on Arch Linux (https://aur.archlinux.org/packages/retdec-git/). But maybe I'll switch to a local installation instead.

By the way: Thanks to all contributors and to Avast for providing that tool as open source software.

@s3rvac
Copy link
Member

s3rvac commented Dec 26, 2017

Currently I have a system wide installation because I use an AUR package on Arch Linux (https://aur.archlinux.org/packages/retdec-git/). But maybe I'll switch to a local installation instead.

The AUR package was created by one of our users and so we cannot provide any guarantees that it works. Until RetDec supports a system-wide installation, we suggest to perform a local installation.

@c-mauderer
Copy link
Author

Yes I know that AUR packages are created by users and not maintained by you. I already created a few for some other packages myself. But some of them are the first step to an official package (supported by the distribution).

I also reported this first to the packager and only when I noted that the name is used throughout your scripts, I reported it here. But like I said: It's not really a problem. A local installation with some prefix is a usable workaround. Users of retdec are most likely developers so that shouldn't be too much of a problem for anyone.

@mewmew
Copy link

mewmew commented Dec 26, 2017

@c-mauderer Thanks for reporting this. Just to note, I uploaded the AUR package. So when a suggested resolution to the problem is presented, I'd be more than happy to include it. I'd personally prefer to limit the changes done to retdec by package distributions, as they will be harder to maintain. If the AUR package were to change the fileinfo name to retdecfileinfo, all scripts using this tool would also have to be updated, and the patches need to be kept in sync with the master branch. As such, it is probably better to wait until retdec renames the fileinfo tool, rather than maintaining local patches. Hope this makes sense, and doesn't create too much of an inconvenience for tesseract users (which has leptonica as a dependency).

@s3rvac
Copy link
Member

s3rvac commented Jan 16, 2018

In the current master, we have renamed our tools so that they are all prefixed with retdec- (3ad168b). For example, instead of fileinfo, we now have retdec-fileinfo.

This should resolve the reported name conflicts, so I am closing this issue.

@c-mauderer
Copy link
Author

Great. Thanks for that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants