Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Start building Mac OS Python wheels for yari-py #14

Open
3 tasks
MatejKastak opened this issue Oct 14, 2022 · 2 comments
Open
3 tasks

Start building Mac OS Python wheels for yari-py #14

MatejKastak opened this issue Oct 14, 2022 · 2 comments
Labels
help wanted Extra attention is needed

Comments

@MatejKastak
Copy link
Member

MatejKastak commented Oct 14, 2022

Currently we support only Linux and Windows platforms.

We should find a way to also build universal MacOS YARI wheels.

  • The first step should be to mention our current limitations in README
  • Then find and document a way to build it on MacOS
  • Optionally prepare a GithubActions workflow for that

PS: If you want to see this implemented in the future, please react to this issue.

@ITAYC0HEN
Copy link

debugger doesn't work on VSCODE on macos, is it related?

@MatejKastak
Copy link
Member Author

Yes it is related, looks like I underestimated how many people run macos. Unfortunately, I don't have a macos available and very little experience with those systems.

We have two options here:

  1. Make it somehow build on MacOS in GithubActions.
  2. Enable source distribution. This will require some tweaks to the upstream YARA, I have a small patch that exposes necessary functions from libyara we are using in YARI (ref). We will need to move that to upstream, which I have in backlog for the upcomming weeks. After that we will be able to link with a system libyara (expecting users to have YARA installed). But the source python distribution should be able to pick this library and link against that.

The first option is better in my opinion, I will start thinking about it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Development

No branches or pull requests

2 participants