Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added disable_access_control attribute to block documentation #485

Merged
merged 28 commits into from
Apr 19, 2022
Merged

added disable_access_control attribute to block documentation #485

merged 28 commits into from
Apr 19, 2022

Conversation

johakoch
Copy link
Collaborator

@johakoch johakoch commented Apr 13, 2022 •
edited
Loading

  • added disable_access_control attribute to block documentation
  • clarified type for several attributes and variables
  • fixed default value for hosts
Reviewer checklist
  • Read PR description: a summary about the changes is required
  • Changelog updated
  • Documentation: docs/{Reference, Cli, ...}, Docker and cli help/usage
  • Pulled branch, manually tested
  • Verified requirements are met
  • Reviewed the code
  • Reviewed the related tests

@johakoch johakoch force-pushed the document-disable_access_control branch from 59d226f to ab82738 Compare April 14, 2022 10:11
@johakoch johakoch marked this pull request as draft April 14, 2022 10:45
@johakoch johakoch marked this pull request as ready for review April 14, 2022 11:45
@johakoch johakoch marked this pull request as draft April 14, 2022 12:53
@johakoch johakoch marked this pull request as ready for review April 14, 2022 14:02
@johakoch johakoch force-pushed the document-disable_access_control branch from 871ffa5 to 162351c Compare April 14, 2022 14:19
@johakoch johakoch force-pushed the document-disable_access_control branch from 4835312 to c8f2f38 Compare April 14, 2022 16:09
@alex-schneider alex-schneider merged commit c58daba into master Apr 19, 2022
@alex-schneider alex-schneider deleted the document-disable_access_control branch April 19, 2022 10:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alex-schneider alex-schneider alex-schneider approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@johakoch @alex-schneider