Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Token request #517

Merged
merged 55 commits into from
Aug 8, 2022
Merged

Token request #517

merged 55 commits into from
Aug 8, 2022

Conversation

johakoch
Copy link
Collaborator

@johakoch johakoch commented Jun 7, 2022

Describe your changes!

Reviewer checklist
  • Read PR description: a summary about the changes is required
  • Changelog updated
  • Documentation: docs/{Reference, Cli, ...}, Docker and cli help/usage
  • Pulled branch, manually tested
  • Verified requirements are met
  • Reviewed the code
  • Reviewed the related tests

@johakoch johakoch force-pushed the token-request branch 4 times, most recently from 59d0968 to 5953e33 Compare June 13, 2022 09:50
@johakoch johakoch force-pushed the token-request branch 5 times, most recently from fede140 to 62eea9a Compare June 22, 2022 11:39
@johakoch johakoch force-pushed the token-request branch 2 times, most recently from 3993510 to a57efa7 Compare July 4, 2022 14:41
@johakoch johakoch force-pushed the token-request branch 3 times, most recently from 29ab08c to a2d584c Compare July 14, 2022 17:16
@johakoch johakoch force-pushed the token-request branch 3 times, most recently from 1f8b0b0 to dc56059 Compare July 22, 2022 11:49
@johakoch johakoch marked this pull request as ready for review July 22, 2022 15:55
@malud malud self-assigned this Aug 1, 2022
@malud malud force-pushed the token-request branch 2 times, most recently from 93d4727 to 4636787 Compare August 4, 2022 09:55
malud
malud previously approved these changes Aug 5, 2022
View reviewed changes
config/token_request.go Outdated Show resolved Hide resolved
Johannes Koch and others added 21 commits August 5, 2022 12:41
remove unused contants
24381fc
fix token response by /token2
a3dc456
refactor test: fail first
c651dc1
test "nested" backend authorization; allow oauth2 to send token reque…
1e28f51 
…st to (oauth2 or beta_token_request) authorized backend; revert to sequential token requests to avoid race problem (to be solved later)
handle expected_status attribute
7d6e8bd
beta_token_request can only have one of body, form_body or json_body …
b52ffb4 
…attributes, too
rename attributes (TODO: find better place, during config load?)
10dee3b
more context to error messages
bb27e40
document beta_backend_token_request error
a6a1fa8
document tokens and token variables for a backend
c4213ad
document beta_token_request block
175aae8
document backend variable
39ce754
document token_response variable
5e7ee30
beta_ prefix new variables and variable properties
7baad63
move attribute documentation to go struct
3d79837
fix TokenRequest pointer receivers
c3260c2
(docs) rm old attr table
82cf49b
solve setting backend variable
143ffdc
token requests in parallel and err handling
7c821fe
add break to retry cond
d8c240e
merge wrap methods
55e307e
@malud malud merged commit b66e38f into master Aug 8, 2022
@malud malud deleted the token-request branch August 8, 2022 17:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@malud malud malud approved these changes

Assignees

@malud malud

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@johakoch @malud