Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pre merge validation #563

Merged
merged 19 commits into from
Aug 31, 2022
Merged

Pre merge validation #563

merged 19 commits into from
Aug 31, 2022

Conversation

johakoch
Copy link
Collaborator

  • Move some config validation pre-merge, in order to find duplicate labels
  • Repeat some validation post-merge
Reviewer checklist
  • Read PR description: a summary about the changes is required
  • Changelog updated
  • Documentation: docs/{Reference, Cli, ...}, Docker and cli help/usage
  • Pulled branch, manually tested
  • Verified requirements are met
  • Reviewed the code
  • Reviewed the related tests

Johannes Koch added 2 commits August 25, 2022 09:27
@johakoch johakoch marked this pull request as ready for review August 25, 2022 08:05
@alex-schneider alex-schneider merged commit 7bc88d7 into master Aug 31, 2022
@alex-schneider alex-schneider deleted the pre-merge-validation branch August 31, 2022 11:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alex-schneider alex-schneider alex-schneider approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@johakoch @alex-schneider