Fix wildcard route match #603
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Compensate for single trailing slashes: * `/p` endpoint matches requests for `/p` and `/p/` but NOT `/p//` * `/p/` endpoint matches requests for `/p` and `/p/` but not `/p//`
afflerbach
force-pushed
the
fix-wildcard-route-match
branch
from
835c47c
to
9aa5540
Compare
afflerbach
force-pushed
the
fix-wildcard-route-match
branch
from
9aa5540
to
f3f5967
Compare
johakoch
requested changes
Sep 30, 2022
johakoch
force-pushed
the
fix-wildcard-route-match
branch
from
4292801
to
6ded8e4
Compare
Co-authored-by: Johannes Koch <53434855+johakoch@users.noreply.github.com>
Co-authored-by: Johannes Koch <53434855+johakoch@users.noreply.github.com>
johakoch
approved these changes
Oct 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix
/**path matching.Reviewer checklist