Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Permission maps files #613

Merged
merged 13 commits into from
Nov 15, 2022
Merged

Permission maps files #613

merged 13 commits into from
Nov 15, 2022

Conversation

johakoch
Copy link
Collaborator

@johakoch johakoch commented Oct 27, 2022 •
edited
Loading

added beta_roles_map_file and beta_permissions_map_file for jwt block

resolves #606

Reviewer checklist
  • Read PR description: a summary about the changes is required
  • Changelog updated
  • Documentation: docs/{Reference, Cli, ...}, Docker and cli help/usage
  • Pulled branch, manually tested
  • Verified requirements are met
  • Reviewed the code
  • Reviewed the related tests

@johakoch johakoch marked this pull request as ready for review October 27, 2022 11:11
Johannes Koch added 13 commits November 15, 2022 11:07
config for beta_roles_map_file and beta_permissions_map_file
e4b748a
enhanced documentation, added 'mutually exclusive' hints
e50d007
added function to read optional JSON mapping object from file or take…
eaa62da 
… provided map
renamed variable
84b2c56
fixed test case input; added new test case
7665584
use function to fill roles/permissions map
c68fe0e
added permission map to test
96653f0
new config error test cases: both key/key_file, beta_roles_map/beta_r…
a303495 
…oles_map_file, beta_permissions_map/beta_permissions_map_file
fix error checking (using regexp to check file reading errors) and jw…
7318b68 
…ks_url with file URL case
new test case: jwks_url with non-existing file
82d67f2
new test cases: beta_roles_map_file/beta_permissions_map_file with no…
ccffd18 
…n-existing file
new integration test cases: beta_roles_map_file/beta_permissions_map_…
afcf1c4 
…file
changelog entry
8318be1
@malud malud merged commit 75fc340 into master Nov 15, 2022
@malud malud deleted the permission-maps-files branch November 15, 2022 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@malud malud malud approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Read permissions maps from a file
2 participants
@johakoch @malud