Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix seq panic #618

Merged
merged 17 commits into from
Nov 9, 2022
Merged

Fix seq panic #618

merged 17 commits into from
Nov 9, 2022

Conversation

malud
Copy link
Collaborator

@malud malud commented Nov 7, 2022 •
edited
Loading

Fix a possible issue(panic) with nested and/or chained sequences with depth > 1.

Reviewer checklist
  • Read PR description: a summary about the changes is required
  • Changelog updated
  • Documentation: docs/{Reference, Cli, ...}, Docker and cli help/usage
  • Pulled branch, manually tested
  • Verified requirements are met
  • Reviewed the code
  • Reviewed the related tests

@malud malud requested a review from johakoch November 7, 2022 17:49
johakoch
johakoch requested changes Nov 8, 2022
View reviewed changes
Copy link
Collaborator

@johakoch johakoch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works. However I'd like the Sequences type to be renamed.

handler/producer/sequence.go Outdated Show resolved Hide resolved
Marcel Ludwig and others added 4 commits November 8, 2022 19:27
@johakoch
Update handler/producer/sequence.go
99d7c43 
Co-authored-by: Johannes Koch <53434855+johakoch@users.noreply.github.com>
@johakoch
Update handler/producer/sequence.go
1839513 
Co-authored-by: Johannes Koch <53434855+johakoch@users.noreply.github.com>
rename seq parallel type
58d5cee
rename parallel type; finally
8210979
johakoch
johakoch reviewed Nov 9, 2022
View reviewed changes
handler/endpoint.go Outdated Show resolved Hide resolved
Marcel Ludwig and others added 5 commits November 9, 2022 14:13
also rename options field
a3c20fc
@johakoch
Update handler/producer/sequence.go
6d13282 
Co-authored-by: Johannes Koch <53434855+johakoch@users.noreply.github.com>
fmt
feaf5bb
fixup
332154c
fixup
cbc7087
@johakoch johakoch merged commit 72a59c8 into release.1.10 Nov 9, 2022
@johakoch johakoch deleted the fix-seq-panic branch November 9, 2022 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@johakoch johakoch johakoch approved these changes

Assignees

@malud malud

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@malud @johakoch