Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use jwt_signing_profile for grant_type jwt-bearer #619

Merged
merged 17 commits into from
Nov 30, 2022
Merged

Use jwt_signing_profile for grant_type jwt-bearer #619

merged 17 commits into from
Nov 30, 2022

Conversation

johakoch
Copy link
Collaborator

@johakoch johakoch commented Nov 8, 2022

  • use nested jwt_signing_profile for grant_type jwt-bearer in the absence of assertion attribute
  • fix evaluation of claims/headers for client_secret_jwt/private_key_jwt
Reviewer checklist
  • Read PR description: a summary about the changes is required
  • Changelog updated
  • Documentation: docs/{Reference, Cli, ...}, Docker and cli help/usage
  • Pulled branch, manually tested
  • Verified requirements are met
  • Reviewed the code
  • Reviewed the related tests

@johakoch johakoch marked this pull request as ready for review November 8, 2022 17:25
@johakoch johakoch force-pushed the use-jwt_signing_profile-for-grant_type-jwt-bearer branch 2 times, most recently from ea0747d to d4fb47b Compare November 22, 2022 09:36
Johannes Koch added 16 commits November 28, 2022 10:08
simplified checking for error cases
8838963
check for set assertion attribute differently
594680a
rename error messages
89a4e24
grant type jwt-bearer: use inline jwt_signing_profile in the absence …
a431343 
…of assertion attribute
add 'grant type jwt-bearer' use case to jwt_signing_profile block doc…
5221252 
…umentation
move reading key bytes
23a63a8
move config checks
38d348e
use JWTSigningConfig for grant type jwt-bearer
037a875
use JWTSigningConfig for client_secret_jwt/private_key_jwt
da4655b
store TTL as int seconds
d1e6844
don't expose functions only used internally
aaa8ee7
removed unused property Name
f7c62a4
less copying of maps; fewer golang-jwt dependencies
069eed2
added information about use of nested jwt_signing_profile blocks
bb91f4f
more quotes around attribute values in documentation
04c6a8f
changelog entry
344e5e2
@johakoch johakoch force-pushed the use-jwt_signing_profile-for-grant_type-jwt-bearer branch from d4fb47b to 344e5e2 Compare November 28, 2022 09:11
@alex-schneider alex-schneider merged commit fe6998d into master Nov 30, 2022
@alex-schneider alex-schneider deleted the use-jwt_signing_profile-for-grant_type-jwt-bearer branch November 30, 2022 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alex-schneider alex-schneider alex-schneider approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@johakoch @alex-schneider