New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Server-Timing HTTP header field #657

Merged

johakoch merged 23 commits into master from server-timing-headers

Jan 17, 2023

Contributor

alex-schneider commented Jan 11, 2023

Describe your changes!

Reviewer checklist

Read PR description: a summary about the changes is required
Changelog updated
Documentation: docs/{Reference, Cli, ...}, Docker and cli help/usage
Pulled branch, manually tested
Verified requirements are met
Reviewed the code
Reviewed the related tests

Alex Schneider added 2 commits

January 12, 2023 16:48


          Implement Server-Timing HTTP header field parser

fde392a


          Implement Server-Timing header

d1483ae

alex-schneider force-pushed the server-timing-headers branch from b8b3964 to d1483ae Compare

January 12, 2023 15:48

Alex Schneider added 4 commits

January 12, 2023 17:48


          Fix panic in test envs

0ff5f5e


          Send our header first

769800f


          Fix test

3b247a0


          Fix test (unordered list)

de24f2c

johakoch linked an issue

that may be closed by this pull request

Provide and extend Server-Timing header #652

Closed

Alex Schneider added 3 commits

January 13, 2023 12:23


          Setting for Server-Timing

bfa8eb7


          Improve docu

434fdd9


          Fix test

6dd7bde

Collaborator

johakoch commented Jan 13, 2023

make generate-docs

johakoch reviewed

View reviewed changes

logging/upstream_log.go Show resolved Hide resolved

johakoch reviewed

View reviewed changes

utils/server_timing.go Outdated Show resolved Hide resolved

johakoch reviewed

View reviewed changes

utils/server_timing.go Show resolved Hide resolved

johakoch reviewed

View reviewed changes

utils/server_timing.go Show resolved Hide resolved

johakoch reviewed

View reviewed changes

logging/upstream_log.go Outdated Show resolved Hide resolved

johakoch reviewed

View reviewed changes

logging/upstream_log.go Show resolved Hide resolved

Alex Schneider added 4 commits

January 14, 2023 11:21


          Update docu

9fe41fa


          Integration test

a9ded4d


          Update comment

7b4281c


          Use const instead of string

4eecf2d

alex-schneider force-pushed the server-timing-headers branch from fb23942 to 0602e80 Compare

January 14, 2023 10:47


          Add 'total' time to the timings

d808ac4

alex-schneider force-pushed the server-timing-headers branch from 0602e80 to d808ac4 Compare

January 14, 2023 10:59

johakoch reviewed

View reviewed changes

config/settings.go Outdated Show resolved Hide resolved

johakoch reviewed

View reviewed changes

config/settings.go Outdated Show resolved Hide resolved

Alex Schneider and others added 3 commits

January 16, 2023 11:28


          Simplify code

d343ea3


          Update config/settings.go

62f8d7b

Co-authored-by: Johannes Koch <53434855+johakoch@users.noreply.github.com>


          Add link in comment

a9ae5d2

Alex Schneider and others added 6 commits

January 16, 2023 11:50


          Update setting name and docs

847ac65


          Change numeration of vars

c905c0d


          headers => header (singular)

74764fb


          Suffix all metrics if at least one collides with other headers

ad1cfae


          Merge branch 'master' into server-timing-headers

e25d087


          Changelog

8e110cf

johakoch approved these changes

View reviewed changes

johakoch merged commit fe0cbcc into master

johakoch deleted the server-timing-headers branch

January 17, 2023 11:56

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet