Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

empty server timing #700

Merged
merged 3 commits into from
Feb 2, 2023
Merged

empty server timing #700

merged 3 commits into from
Feb 2, 2023

Conversation

johakoch
Copy link
Collaborator

@johakoch johakoch commented Feb 1, 2023

Don't send empty Server-Timing header.

Reviewer checklist
  • Read PR description: a summary about the changes is required
  • Changelog updated
  • Documentation: docs/{Reference, Cli, ...}, Docker and cli help/usage
  • Pulled branch, manually tested
  • Verified requirements are met
  • Reviewed the code
  • Reviewed the related tests

@johakoch johakoch linked an issue Feb 1, 2023 that may be closed by this pull request
Empty Server-Timing header #685
Closed
@johakoch johakoch marked this pull request as ready for review February 1, 2023 10:28
@alex-schneider alex-schneider merged commit 563e4a5 into master Feb 2, 2023
@alex-schneider alex-schneider deleted the 685-empty-server-timing branch February 2, 2023 11:04
@johakoch johakoch mentioned this pull request Feb 10, 2023
Closed
johakoch added a commit that referenced this pull request Feb 13, 2023
@johakoch
empty server timing (#700)
659cf60 
* test for no (instead of empty) Server-Timing header

* don't send Server-Timing header if result map is empty

* changelog entry
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alex-schneider alex-schneider alex-schneider approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Empty Server-Timing header
2 participants
@johakoch @alex-schneider