Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix watch resource leak #736

Merged
merged 4 commits into from
Mar 3, 2023
Merged

Fix watch resource leak #736

merged 4 commits into from
Mar 3, 2023

Conversation

malud
Copy link
Collaborator

@malud malud commented Mar 3, 2023

Closes #692

Reviewer checklist
  • Read PR description: a summary about the changes is required
  • Changelog updated
  • Documentation: docs/{Reference, Cli, ...}, Docker and cli help/usage
  • Pulled branch, manually tested
  • Verified requirements are met
  • Reviewed the code
  • Reviewed the related tests

@malud malud added this to the 1.12.1 milestone Mar 3, 2023
@malud malud requested a review from johakoch March 3, 2023 06:57
@malud malud changed the base branch from master to release.1.12 March 3, 2023 06:57
@johakoch
Copy link
Collaborator

johakoch commented Mar 3, 2023

This fixes the issue with multiple health probes and multiple jobs. Passing request.ConfigDryRun to jobs doesn't seem necessary.

johakoch
johakoch requested changes Mar 3, 2023
View reviewed changes
Copy link
Collaborator

@johakoch johakoch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changelog entry missing

@johakoch johakoch merged commit fb9cce3 into release.1.12 Mar 3, 2023
@johakoch johakoch deleted the fix-watch-resource-leak branch March 3, 2023 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@johakoch johakoch johakoch approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.12.1
Development

Successfully merging this pull request may close these issues.

NewServerConfiguration() called twice after config reload with -watch causing e.g. double health probes/jobs
2 participants
@malud @johakoch