Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

738 parse cert with trailing stuff #739

Merged
merged 3 commits into from
Mar 7, 2023
Merged

738 parse cert with trailing stuff #739

merged 3 commits into from
Mar 7, 2023

Conversation

johakoch
Copy link
Collaborator

@johakoch johakoch commented Mar 6, 2023

readCertificateFile() ignoring trailing stuff, but failing if PEM doesn't contain any X509 certificate

Reviewer checklist
  • Read PR description: a summary about the changes is required
  • Changelog updated
  • Documentation: docs/{Reference, Cli, ...}, Docker and cli help/usage
  • Pulled branch, manually tested
  • Verified requirements are met
  • Reviewed the code
  • Reviewed the related tests

@johakoch johakoch linked an issue Mar 6, 2023 that may be closed by this pull request
couper doesn't recognize PEM file format with new line at the end of a file #738
Closed
@johakoch johakoch requested a review from malud March 6, 2023 10:40
@johakoch johakoch force-pushed the 738-parse-cert-with-trailing-stuff branch from 053ecc3 to a642729 Compare March 6, 2023 10:41
@johakoch johakoch changed the base branch from master to release.1.12 March 6, 2023 10:41
@johakoch johakoch marked this pull request as ready for review March 6, 2023 10:46
@alex-schneider alex-schneider merged commit 4856fd6 into release.1.12 Mar 7, 2023
@alex-schneider alex-schneider deleted the 738-parse-cert-with-trailing-stuff branch March 7, 2023 11:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alex-schneider alex-schneider alex-schneider approved these changes

@malud malud Awaiting requested review from malud

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

couper doesn't recognize PEM file format with new line at the end of a file
2 participants
@johakoch @alex-schneider