feat: Updated linter implementation to generate effective-pom for parsing pom.xml #158
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sing pom.xml Updated linter implementation to generate effective-pom for parsing pom.xml. And, updated existing test case to handle scenarios with effective-pom
adesjardin
requested changes
Aug 30, 2023
Comment on lines
49
to
50
| violations[0].lineNumber == 2 | ||
| violations[0].fileName.endsWith('pom.xml') | ||
| violations[0].rule.ruleId == MuleArtifactMinMuleVersionRule.RULE_ID |
There was a problem hiding this comment.
If this rule referenced the pom wouldn't its line number now be 0 as well like the other pom rules you changed?
| @@ -35,17 +35,17 @@ class PomArtifactAttributeRuleTest extends Specification { | |||
|
|
|||
| then: | |||
| violations.size() == 1 | |||
| violations[0].fileName.contains('pom.xml') | |||
| // violations[0].fileName.contains('pom.xml') | |||
There was a problem hiding this comment.
This should be removed if not used, not commented
Fixed review comments - 1. Removed commented code. 2. Updated the filename in MULE_ARTIFACT_MIN_MULE_VERSION rule violation to return mule-artifact.json file
adesjardin
approved these changes
Aug 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated linter implementation to generate effective-pom for parsing pom.xml.
And, updated existing test case to handle scenarios with effective-pom