Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

search is broken on Windows #506

Closed
zhelyan opened this issue May 11, 2024 · 4 comments · Fixed by #517 or #557
Closed

search is broken on Windows #506

zhelyan opened this issue May 11, 2024 · 4 comments · Fixed by #517 or #557
Labels
bug Something isn't working

Comments

@zhelyan
Copy link
Contributor

zhelyan commented May 11, 2024

Small issue - searching from a component view is broken as relative paths use the windows file separator \ - i.e the relative path is not a http path

@zhelyan zhelyan changed the title search is broken on Wondows search is broken on Windows May 11, 2024
@dirkgroot
Copy link
Collaborator

Hi @zhelyan, thanks for reporting!

I've made a potential fix for this issue, but unfortunately, I don't have easy access to a Windows computer to test this. Could you try if this fixes your issue?

You can download the binaries containing this fix using the following URL: https://github.com/avisi-cloud/structurizr-site-generatr/actions/runs/9170553411/artifacts/1521911067

@zhelyan
Copy link
Contributor Author

zhelyan commented Jun 13, 2024

@dirkgroot sorry for the late reply

It is still broken unfortunately. I think the issue is that the method constructs file paths using platform dependant separators. They need to be normalized to http compliant paths. Perhaps the simplest thing to do would be e.g

URI(relativeTo + "/" + this).normalize().toURL().toString()

@jp7677
Copy link
Contributor

jp7677 commented Jul 2, 2024

Another attempt for this issue: #557

@jp7677 jp7677 added the bug Something isn't working label Jul 2, 2024
@jp7677
Copy link
Contributor

jp7677 commented Jul 3, 2024

@zhelyan I've merged the PR since this change is a good idea anyway. Feel free to reopen if this issue still exists.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
3 participants