From 23c9006442853c7d86d62c3ad3b9d5502af70af1 Mon Sep 17 00:00:00 2001 From: Andreas Kling Date: Wed, 3 Apr 2024 12:50:39 +0200 Subject: [PATCH] LibWeb: Remove unnecessary JS::Handle in AbortSignal::timeout() This fixes yet another GC reference cycle. --- Userland/Libraries/LibWeb/DOM/AbortSignal.cpp | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/Userland/Libraries/LibWeb/DOM/AbortSignal.cpp b/Userland/Libraries/LibWeb/DOM/AbortSignal.cpp index 369214270a5a0f..fa79c32e6f5409 100644 --- a/Userland/Libraries/LibWeb/DOM/AbortSignal.cpp +++ b/Userland/Libraries/LibWeb/DOM/AbortSignal.cpp @@ -138,11 +138,11 @@ WebIDL::ExceptionOr> AbortSignal::timeout(JS::VM& VERIFY(window_or_worker); // 3. Run steps after a timeout given global, "AbortSignal-timeout", milliseconds, and the following step: - window_or_worker->run_steps_after_a_timeout(milliseconds, [&realm, &global, strong_signal = JS::make_handle(signal)]() { + window_or_worker->run_steps_after_a_timeout(milliseconds, [&realm, &global, signal]() { // 1. Queue a global task on the timer task source given global to signal abort given signal and a new "TimeoutError" DOMException. - HTML::queue_global_task(HTML::Task::Source::TimerTask, global, [&realm, &strong_signal]() mutable { + HTML::queue_global_task(HTML::Task::Source::TimerTask, global, [&realm, signal]() mutable { auto reason = WebIDL::TimeoutError::create(realm, "Signal timed out"_fly_string); - strong_signal->signal_abort(reason); + signal->signal_abort(reason); }); });