feat: ability to configure log driver and log options #255
Conversation
index.js
Outdated
| @@ -70,6 +73,29 @@ async function run() { | |||
| }) | |||
| } | |||
|
|
|||
| if (logConfigurationLogDriver) { | |||
| if (!containerDef.logConfiguration) { containerDef.logConfiguration = {} } | |||
| const validDrivers = ["json-file", "syslog", "journald", "gelf", "fluentd", "awslogs", "splunk", "awsfirelens"]; | |||
There was a problem hiding this comment.
Currently for the ECS task, these are the log configurations that are supported.
For tasks on AWS Fargate, the supported log drivers are awslogs, splunk, and awsfirelens
For tasks hosted on Amazon EC2 instances, the supported log drivers are awslogs, fluentd, gelf, json-file, journald, logentries, syslog, splunk, and awsfirelens.
Are we assuming these drivers for ECS Tasks based on Ec2 instance? if this is the case do we need to add logentries as well ?
There was a problem hiding this comment.
my current scenario is for fargate but yes, let's add logentries!
index.js
Outdated
| if (logConfigurationLogDriver) { | ||
| if (!containerDef.logConfiguration) { containerDef.logConfiguration = {} } | ||
| const validDrivers = ["json-file", "syslog", "journald", "gelf", "fluentd", "awslogs", "splunk", "awsfirelens"]; | ||
| if (!validDrivers.find(driver => driver === logConfigurationLogDriver)) { |
There was a problem hiding this comment.
can this be simplified?
if (!validDrivers.includes(logConfigurationLogDriver)){
throw new Error(`'${logConfigurationLogDriver}' is invalid logConfigurationLogDriver. valid options are ${validDrivers}. More details: https://docs.aws.amazon.com/AmazonECS/latest/APIReference/API_LogConfiguration.html`)
}
There was a problem hiding this comment.
i could remove the link to the documentation or the valid options list. what do you think?
There was a problem hiding this comment.
what i mean by this comment is that
instead of using array function in L79. if (!validDrivers.find(driver => driver === logConfigurationLogDriver))
can you just use if (!validDrivers.includes(logConfigurationLogDriver))?
|
Looks like i do not have any write access to merge the PR. I will contact the right person to merge this PR. |
|
Hi, it would be nice to create a release that contains this feature. Thx. |
|
Yeah, can we create a release? Looks like a release hasn't been created since January |
Issue #254
Description of changes:
For my workflow i need to override the
awslogs-groupvalue so it doesn't clash with other group names. app on dev environment and app on staging would override messages if the task definition file is shared between them, and turns out it is.By having a chance to override log configuration i can rename the property without having to keep different versions of the same task definiton.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.