role-skip-session-tagging: false skips session tagging

[gabegorelick]

getInput always returns a string, and this action doesn't convert the return value to a boolean. So if you specify role-skip-session-tagging: false, you won't get session tagging.

configure-aws-credentials/index.js

Line 206 in 3042b00

const roleSkipSessionTagging = core.getInput('role-skip-session-tagging', { required: false });

configure-aws-credentials/index.js

Line 58 in 3042b00

const roleSessionTags = roleSkipSessionTagging ? undefined : tagArray;

The obvious workaround is to just remove the role-skip-session-tagging option instead of specifying role-skip-session-tagging: false, but it's definitely confusing that role-skip-session-tagging: false doesn't work as expected.

[allisaurus]

Thanks for reporting @gabegorelick ! Agreed this is not expected behavior, will work on setting this right.

[allisaurus]

This should be fixed in 1.5.10!