Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: internal add auth entry point #5281

Merged
merged 1 commit into from
Sep 9, 2020

Conversation

edwardfoyle
Copy link
Contributor

Issue #, if available:

Description of changes:
Internal calls to add auth use a different entry point into the category which had some logic that was duplicated since the refactor

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@edwardfoyle edwardfoyle requested a review from attilah September 9, 2020 00:37
@attilah attilah self-assigned this Sep 9, 2020
@codecov
Copy link

codecov bot commented Sep 9, 2020

Codecov Report

Merging #5281 into master will decrease coverage by 0.00%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5281      +/-   ##
==========================================
- Coverage   60.37%   60.36%   -0.01%     
==========================================
  Files         391      391              
  Lines       17177    17178       +1     
  Branches     3397     3215     -182     
==========================================
  Hits        10370    10370              
- Misses       6251     6272      +21     
+ Partials      556      536      -20     
Impacted Files Coverage Δ
...awscloudformation/handlers/get-add-auth-handler.ts 29.41% <0.00%> (-1.84%) ⬇️
...udformation/utils/post-add-auth-message-printer.ts 12.50% <0.00%> (ø)
packages/amplify-util-mock/src/api/api.ts 0.00% <0.00%> (ø)
packages/graphql-mapping-template/src/print.ts 34.65% <0.00%> (ø)
packages/amplify-util-mock/src/storage/storage.ts 0.00% <0.00%> (ø)
...ges/amplify-util-mock/src/CFNParser/stack/index.ts 0.00% <0.00%> (ø)
...es/amplify-util-mock/src/api/resolver-overrides.ts 0.00% <0.00%> (ø)
...es/graphql-transformer-core/src/stripDirectives.ts 35.29% <0.00%> (ø)
.../amplify-cli-core/src/state-manager/pathManager.ts 42.18% <0.00%> (ø)
.../amplify-util-mock/src/utils/lambda/loadMinimal.ts 0.00% <0.00%> (ø)
... and 11 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 963b47c...d3973eb. Read the comment docs.

@edwardfoyle edwardfoyle merged commit 59734ac into aws-amplify:master Sep 9, 2020
Jhorlin pushed a commit to Jhorlin/amplify-cli that referenced this pull request Sep 10, 2020
Co-authored-by: Edward Foyle <foyleef@.amazon.com>
@github-actions
Copy link

This pull request has been automatically locked since there hasn't been any recent activity after it was closed. Please open a new issue for related bugs.

Looking for a help forum? We recommend joining the Amplify Community Discord server *-help channels for those types of questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 10, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants