Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: checking undefined auth config #5313

Merged
merged 2 commits into from
Sep 11, 2020
Merged

Conversation

akshbhu
Copy link
Contributor

@akshbhu akshbhu commented Sep 11, 2020

*Issue:#5240

Description of changes:

  • checks for null Config in add api flow

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@akshbhu akshbhu requested a review from edwardfoyle September 11, 2020 20:48
@codecov
Copy link

codecov bot commented Sep 11, 2020

Codecov Report

Merging #5313 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #5313   +/-   ##
=======================================
  Coverage   59.86%   59.86%           
=======================================
  Files         391      391           
  Lines       17469    17469           
  Branches     3288     3288           
=======================================
  Hits        10458    10458           
  Misses       6408     6408           
  Partials      603      603           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8747911...ea66c15. Read the comment docs.

Copy link
Contributor

@edwardfoyle edwardfoyle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one nit but lgtm

@akshbhu akshbhu merged commit 42810c9 into aws-amplify:master Sep 11, 2020
@github-actions
Copy link

This pull request has been automatically locked since there hasn't been any recent activity after it was closed. Please open a new issue for related bugs.

Looking for a help forum? We recommend joining the Amplify Community Discord server *-help channels for those types of questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 12, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants