fix(amplify-appsync-simulator): make ExpressionAttributeNames optional #5575
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When you map a unit or a function to use a DynamoDB data source and use the operation UpdateItem and do not set condition.expressionNames or update.expressionNames in the payload the amplify-appsync-simulator stops execution. The AppSync DynamoDB template reference says that those attributes are optional. fix aws-amplify#5573
Codecov Report
@@ Coverage Diff @@
## master #5575 +/- ##
==========================================
- Coverage 59.08% 59.08% -0.01%
==========================================
Files 402 402
Lines 18043 18045 +2
Branches 3575 3390 -185
==========================================
Hits 10661 10661
- Misses 6723 6745 +22
+ Partials 659 639 -20
Continue to review full report at Codecov.
|
r0zar
pushed a commit
to r0zar/amplify-cli
that referenced
this pull request
Nov 19, 2020
aws-amplify#5575) When you map a unit or a function to use a DynamoDB data source and use the operation UpdateItem and do not set condition.expressionNames or update.expressionNames in the payload the amplify-appsync-simulator stops execution. The AppSync DynamoDB template reference says that those attributes are optional. fix aws-amplify#5573 Co-authored-by: Fernando Chucre <fernando@oraoncology.com>
|
This pull request has been automatically locked since there hasn't been any recent activity after it was closed. Please open a new issue for related bugs. Looking for a help forum? We recommend joining the Amplify Community Discord server |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When you map a unit or a function to use a DynamoDB data source and use the operation UpdateItem and
do not set condition.expressionNames or update.expressionNames in the payload the
amplify-appsync-simulator stops execution. The AppSync DynamoDB template reference says that those
attributes are optional.
Issue #, if available:
fix #5573
Description of changes:
Replace to null if the object is empty, the same approach used in the
Queryoperator.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.