feat: added new fields to usage data #6911
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cjihrig
approved these changes
Mar 23, 2021
added 3 commits
March 29, 2021 10:49
Added * project setting * accountId
ammarkarachi
force-pushed
the
feat/usage-data-addition-fields
branch
from
db5cd97 to
221a8bd
Compare
edwardfoyle
reviewed
Apr 2, 2021
packages/amplify-cli/src/domain/amplify-usageData/NoUsageData.ts
Outdated
Show resolved
Hide resolved
| this.version = version; | ||
| this.inputOptions = input.options ? _.pick(input.options as InputOptions, ['sandboxId']) : {}; |
There was a problem hiding this comment.
is this only storing the sandboxId? if so, I'd just name it that. Also, does this simplify to:
Suggested change
| this.inputOptions = input.options ? _.pick(input.options as InputOptions, ['sandboxId']) : {}; | |
| this.inputOptions = input?.options?.sandboxId || {}; |
There was a problem hiding this comment.
No we are going to extend this in the future, this is there to add more field if needed in the future
packages/amplify-cli/src/domain/amplify-usageData/UsageDataPayload.ts
Outdated
Show resolved
Hide resolved
packages/amplify-provider-awscloudformation/src/aws-utils/aws-sts.ts
Outdated
Show resolved
Hide resolved
jhockett
changed the title
github-actions
bot
added
the
referenced-in-release
|
👋 Hi, this pull request was referenced in the v4.48.0 release! Check out the release notes here https://github.com/aws-amplify/amplify-cli/releases/tag/v4.48.0. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
Added additional fields to the usage data payload.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.