Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cli): display gql schema errors on failed push #7001

Merged
merged 1 commit into from
Apr 9, 2021
Merged

fix(cli): display gql schema errors on failed push #7001

merged 1 commit into from
Apr 9, 2021

Conversation

cjihrig
Copy link
Contributor

@cjihrig cjihrig commented Mar 31, 2021

Description of changes

This commit updates the push error handling to show the full schema errors from GraphQL compilation.

Issue #, if available

#6999

Description of how you validated changes

Attempted to push a GraphQL schema with errors and verified that all of the schema details were displayed.

Checklist

  • PR description included
  • yarn test passes

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

This commit updates the push error handling to show the full
schema errors from GraphQL compilation.

Refs: #6999
@cjihrig cjihrig requested a review from a team as a code owner March 31, 2021 21:19
@codecov
Copy link

codecov bot commented Mar 31, 2021

Codecov Report

Merging #7001 (775ee9d) into master (27030ea) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #7001   +/-   ##
=======================================
  Coverage   56.41%   56.41%           
=======================================
  Files         445      445           
  Lines       21764    21764           
  Branches     4354     4354           
=======================================
  Hits        12278    12278           
  Misses       8671     8671           
  Partials      815      815           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 27030ea...775ee9d. Read the comment docs.

@cjihrig cjihrig linked an issue Mar 31, 2021 that may be closed by this pull request
@jhockett jhockett merged commit 3e88993 into aws-amplify:master Apr 9, 2021
@github-actions github-actions bot added the referenced-in-release Issues referenced in a published release changelog label Apr 14, 2021
@github-actions
Copy link

👋 Hi, this pull request was referenced in the v4.48.0 release!

Check out the release notes here https://github.com/aws-amplify/amplify-cli/releases/tag/v4.48.0.

@cjihrig cjihrig deleted the err-msg branch September 30, 2021 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
referenced-in-release Issues referenced in a published release changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Syntax error on graphql schema
4 participants