Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: lambda layer change handling #7537

Merged
merged 3 commits into from
Jun 17, 2021
Merged

fix: lambda layer change handling #7537

merged 3 commits into from
Jun 17, 2021

Conversation

attilah
Copy link
Contributor

@attilah attilah commented Jun 17, 2021

Description of changes

This PR fixes 2 issues around lambda functions:

  • update function previously failed when the selected function referenced a non-existent lambda layer version
  • when project had 2 lambda layers and both of them had changes a push failed because CFN logical resource id was the same

Issue #, if available

N/A

Description of how you validated changes

Manual testing

Checklist

  • PR description included
  • yarn test passes
  • Tests are changed or added
  • Relevant documentation is changed or added (and PR referenced)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@attilah attilah requested a review from cjihrig June 17, 2021 17:50
@attilah attilah requested a review from a team as a code owner June 17, 2021 17:50
@ammarkarachi ammarkarachi merged commit 9b7a6b7 into aws-amplify:master Jun 17, 2021
@github-actions github-actions bot added the referenced-in-release Issues referenced in a published release changelog label Jun 19, 2021
@github-actions
Copy link

👋 Hi, this pull request was referenced in the v5.0.1 release!

Check out the release notes here https://github.com/aws-amplify/amplify-cli/releases/tag/v5.0.1.

cjihrig pushed a commit to ctjlewis/amplify-cli that referenced this pull request Jul 12, 2021
* fix: layer CFN generation for multiple layers

* refactor: change latestVersionLogicalId handling

* fix: update function fails when a previously assigned layer does not exists
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
referenced-in-release Issues referenced in a published release changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants