fix(cli): better error message when trying to publish with CD configured in Amplify Console #7874
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
cjihrig
added a commit
that referenced
this pull request
Aug 26, 2021
This was causing E2E test failures. Refs: #7874 Co-authored-by: Colin Ihrig <colihrig@amazon.com>
|
👋 Hi, this pull request was referenced in the v5.4.0 release! Check out the release notes here https://github.com/aws-amplify/amplify-cli/releases/tag/v5.4.0. |
github-actions
bot
added
the
referenced-in-release
jhockett
pushed a commit
that referenced
this pull request
Sep 7, 2021
… configured in Amplify Console (#7874) (#8106) * Revert "fix: handle case where there is no appId (#8049)" This reverts commit f7e62df. The commit being reverted builds on top of another commit that is being reverted. * Revert "fix(cli): better error message when trying to publish with CD configured in Amplify Console (#7874)" This reverts commit 4f03859. The commit being reverted causes a number of customer bug reports in verion 5.4.0. Co-authored-by: Colin Ihrig <colihrig@amazon.com>
|
👋 Hi, this pull request was referenced in the v5.5.0 release! Check out the release notes here https://github.com/aws-amplify/amplify-cli/releases/tag/v5.5.0. |
marcvberg
pushed a commit
to marcvberg/amplify-cli
that referenced
this pull request
Oct 13, 2021
…red in Amplify Console (aws-amplify#7874) * fix(cli): add specific check for cd branches when running `amplify publish` fix aws-amplify#7486 * test(cli): add tests for hasCdBranches * refactor(cli): mockBranches explicit values set per-test
marcvberg
pushed a commit
to marcvberg/amplify-cli
that referenced
this pull request
Oct 13, 2021
This was causing E2E test failures. Refs: aws-amplify#7874 Co-authored-by: Colin Ihrig <colihrig@amazon.com>
marcvberg
pushed a commit
to marcvberg/amplify-cli
that referenced
this pull request
Oct 13, 2021
… configured in Amplify Console (aws-amplify#7874) (aws-amplify#8106) * Revert "fix: handle case where there is no appId (aws-amplify#8049)" This reverts commit f7e62df. The commit being reverted builds on top of another commit that is being reverted. * Revert "fix(cli): better error message when trying to publish with CD configured in Amplify Console (aws-amplify#7874)" This reverts commit 4f03859. The commit being reverted causes a number of customer bug reports in verion 5.4.0. Co-authored-by: Colin Ihrig <colihrig@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Running
amplify publishwill now error with "You have already connected branches to your Amplify Console app. Please visit the Amplify Console to manage your branches." when CD is configured in the Amplify Console, re #7486.Issue #, if available
fix #7486
Description of how you validated changes
amplify initin new react projectmainbranch to frontend on Amplify Consoleamplify-dev publishamplify initanother react projectamplify-dev publishwithout adding hosting or connecting a branchyarn testyarn lintChecklist
yarn testpassesBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.