fix(amplify-cli-core): extend js-yaml.JSON_SCHEMA to inherit json type conversions when parsing .yml cfn templates #7909
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e conversions Instead of creating a js-yaml schema that only contains conversions for cloudformation intrinsic functions, we should extend the built-in JSON-SCHEMA to inherit type conversions for bools, ints, floats, etc. fix aws-amplify#7819
|
Can you add some regression tests. |
|
Yeah, for sure! |
cjihrig
approved these changes
Aug 11, 2021
jhockett
pushed a commit
that referenced
this pull request
Aug 25, 2021
…e conversions when parsing .yml cfn templates (#7909) * fix(amplify-cli-core): extend js-yaml.JSON_SCHEMA to inherit json type conversions Instead of creating a js-yaml schema that only contains conversions for cloudformation intrinsic functions, we should extend the built-in JSON-SCHEMA to inherit type conversions for bools, ints, floats, etc. fix #7819 * test(amplify-cli-core): add regression tests
github-actions
bot
added
the
referenced-in-release
|
👋 Hi, this pull request was referenced in the v5.4.0 release! Check out the release notes here https://github.com/aws-amplify/amplify-cli/releases/tag/v5.4.0. |
marcvberg
pushed a commit
to marcvberg/amplify-cli
that referenced
this pull request
Oct 13, 2021
…e conversions when parsing .yml cfn templates (aws-amplify#7909) * fix(amplify-cli-core): extend js-yaml.JSON_SCHEMA to inherit json type conversions Instead of creating a js-yaml schema that only contains conversions for cloudformation intrinsic functions, we should extend the built-in JSON-SCHEMA to inherit type conversions for bools, ints, floats, etc. fix aws-amplify#7819 * test(amplify-cli-core): add regression tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Instead of creating a js-yaml schema that only contains conversions for cloudformation intrinsic
functions, we extend the built-in JSON-SCHEMA to inherit type conversions for bools, ints,
floats, etc.
See https://github.com/nodeca/js-yaml#load-string---options-
Issue #, if available
fix #7819
Description of how you validated changes
yarn testyarn lintChecklist
yarn testpassesBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.