Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: #5372 - cut signing url ending slash when matching in mock #5434

Merged
merged 1 commit into from
Sep 28, 2020
Merged

fix: #5372 - cut signing url ending slash when matching in mock #5434

merged 1 commit into from
Sep 28, 2020

Conversation

attilah
Copy link
Contributor

@attilah attilah commented Sep 28, 2020

Issue #, if available:

fix: #5372

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@attilah attilah requested a review from yuth September 28, 2020 21:00
@codecov
Copy link

codecov bot commented Sep 28, 2020

Codecov Report

Merging #5434 into master will increase coverage by 0.00%.
The diff coverage is 78.57%.

Impacted file tree graph

@@           Coverage Diff            @@
##           master    #5434    +/-   ##
========================================
  Coverage   59.12%   59.12%            
========================================
  Files         399      399            
  Lines       17968    17975     +7     
  Branches     3370     3562   +192     
========================================
+ Hits        10623    10628     +5     
+ Misses       6718     6698    -20     
- Partials      627      649    +22     
Impacted Files Coverage Δ
packages/amplify-category-auth/src/index.js 10.73% <0.00%> (ø)
...psync-model-plugin/src/visitors/appsync-visitor.ts 95.67% <ø> (ø)
...ppsync-simulator/src/utils/auth-helpers/helpers.ts 77.77% <50.00%> (-4.58%) ⬇️
...ugin/src/visitors/appsync-json-metadata-visitor.ts 94.52% <50.00%> (-1.26%) ⬇️
...en-appsync-model-plugin/src/utils/get-type-info.ts 90.00% <100.00%> (+2.50%) ⬆️
...ify-codegen/src/utils/getSchemaDownloadLocation.js 100.00% <100.00%> (ø)
packages/amplify-util-mock/src/api/api.ts 0.00% <0.00%> (ø)
packages/graphql-mapping-template/src/print.ts 34.65% <0.00%> (ø)
packages/amplify-util-mock/src/storage/storage.ts 0.00% <0.00%> (ø)
...ges/amplify-util-mock/src/CFNParser/stack/index.ts 0.00% <0.00%> (ø)
... and 16 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update afbe065...5a8296e. Read the comment docs.

@github-actions
Copy link

This pull request has been automatically locked since there hasn't been any recent activity after it was closed. Please open a new issue for related bugs.

Looking for a help forum? We recommend joining the Amplify Community Discord server *-help channels for those types of questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 29, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AppSync mock oidc issuer check does not take ending forward slash into consideration.
2 participants