Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: headless auth username attributes must be an array #5467

Merged
merged 1 commit into from
Oct 1, 2020

Conversation

edwardfoyle
Copy link
Contributor

The headless add auth transformer set username attributes as a string instead of an array causing CFN failures.
Note this error is only encountered in headless mode, not when using the auth walkthrough

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Copy link
Contributor

@kaustavghosh06 kaustavghosh06 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@codecov
Copy link

codecov bot commented Oct 1, 2020

Codecov Report

Merging #5467 into master will increase coverage by 0.10%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5467      +/-   ##
==========================================
+ Coverage   59.03%   59.14%   +0.10%     
==========================================
  Files         402      402              
  Lines       18068    18068              
  Branches     3580     3393     -187     
==========================================
+ Hits        10667    10686      +19     
+ Misses       6747     6744       -3     
+ Partials      654      638      -16     
Impacted Files Coverage Δ
...s/awscloudformation/utils/auth-request-adaptors.ts 40.20% <ø> (+19.58%) ⬆️
packages/amplify-util-mock/src/api/api.ts 0.00% <0.00%> (ø)
packages/graphql-mapping-template/src/print.ts 34.65% <0.00%> (ø)
packages/amplify-util-mock/src/storage/storage.ts 0.00% <0.00%> (ø)
...ges/amplify-util-mock/src/CFNParser/stack/index.ts 0.00% <0.00%> (ø)
...es/amplify-util-mock/src/api/resolver-overrides.ts 0.00% <0.00%> (ø)
...es/graphql-transformer-core/src/stripDirectives.ts 35.29% <0.00%> (ø)
.../amplify-cli-core/src/state-manager/pathManager.ts 70.42% <0.00%> (ø)
.../amplify-util-mock/src/utils/lambda/loadMinimal.ts 0.00% <0.00%> (ø)
...graphql-transformer-core/src/TransformerContext.ts 24.81% <0.00%> (ø)
... and 11 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 23f8bbd...3b65a2a. Read the comment docs.

@edwardfoyle edwardfoyle merged commit dbde67c into aws-amplify:master Oct 1, 2020
yuth pushed a commit to yuth/amplify-cli that referenced this pull request Oct 2, 2020
r0zar pushed a commit to r0zar/amplify-cli that referenced this pull request Nov 19, 2020
@github-actions
Copy link

github-actions bot commented Oct 2, 2021

This pull request has been automatically locked since there hasn't been any recent activity after it was closed. Please open a new issue for related bugs.

Looking for a help forum? We recommend joining the Amplify Community Discord server *-help channels for those types of questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 2, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants