Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(amplify-appsync-simulator): allow token.iss ending with slash #6364

Merged
merged 1 commit into from
Jan 14, 2021

Conversation

safonovklim
Copy link
Contributor

@safonovklim safonovklim commented Jan 11, 2021

Issue: #6368

#5372 (comment)

Description of changes:

  • Improved isValidOIDCToken(): Added support for token.iss ending with slash. (Auth0)
  • Added unit tests

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Copy link
Contributor

@attilah attilah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@safonovklim thanks for the fix, LGTM!

@safonovklim
Copy link
Contributor Author

@attilah thank you for reviewing this PR!

Can you give estimate when this fix will be merged and released? I'm not sure about next steps...

Thank you!

@attilah attilah merged commit cba5c4d into aws-amplify:master Jan 14, 2021
@attilah
Copy link
Contributor

attilah commented Jan 14, 2021

@safonovklim will be in the next release.

@safonovklim
Copy link
Contributor Author

@attilah awesome!! thank you!

@github-actions
Copy link

This pull request has been automatically locked since there hasn't been any recent activity after it was closed. Please open a new issue for related bugs.

Looking for a help forum? We recommend joining the Amplify Community Discord server *-help channels for those types of questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 15, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

amplify-appsync-simulator - 401 for token.iss ending with forward slash
2 participants