-
Notifications
You must be signed in to change notification settings - Fork 825
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add global sandbox mode #8063
Closed
danielleadams
wants to merge
9
commits into
aws-amplify:master
from
danielleadams:enable-sandbox-mode
Closed
Add global sandbox mode #8063
danielleadams
wants to merge
9
commits into
aws-amplify:master
from
danielleadams:enable-sandbox-mode
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danielleadams
force-pushed
the
enable-sandbox-mode
branch
from
August 30, 2021 20:00
99cba4c
to
0b48a76
Compare
Codecov Report
@@ Coverage Diff @@
## master #8063 +/- ##
==========================================
+ Coverage 54.14% 54.18% +0.04%
==========================================
Files 657 660 +3
Lines 37484 37558 +74
Branches 7696 7718 +22
==========================================
+ Hits 20295 20351 +56
- Misses 16349 16367 +18
Partials 840 840
Continue to review full report at Codecov.
|
This comment has been minimized.
This comment has been minimized.
danielleadams
force-pushed
the
enable-sandbox-mode
branch
from
August 31, 2021 18:21
ecab350
to
036e806
Compare
danielleadams
force-pushed
the
enable-sandbox-mode
branch
from
August 31, 2021 19:08
036e806
to
2817701
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
This adds the global sandbox mode for transformer v2. The transformer uses the presence of
type AMPLIFY_GLOBAL @allow_public_data_access_with_api_key(env: string)
in the GraphQL schema. The API must have an API_KEY associated with the API resource in order to use Global Sandbox Mode.Includes:
type AMPLIFY_GLOBAL @allow_public_data_access_with_api_key
to generated schemas onapi add
amplify status
amplify push
when key is expired or absent and sandbox mode is enabledDescription of how you validated changes
Unit tests were added to test the individual code functionality. Also, an e2e test was added to test generating the GraphQL schema with the directive and pushing resources. Additionally, functionality was testing locally in development environment.
Checklist
yarn test
passesBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.