-
Notifications
You must be signed in to change notification settings - Fork 825
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(amplify-category-auth): update front end config on pull #8093
Conversation
When running /* eslint-disable */
// WARNING: DO NOT EDIT. This file is automatically generated by AWS Amplify. It will be overwritten.
const awsmobile = {
"aws_project_region": "us-east-1",
"aws_cognito_identity_pool_id": "us-east-1:******",
"aws_cognito_region": "us-east-1",
"aws_user_pools_id": "us-east-1_******",
"aws_user_pools_web_client_id": "******",
"oauth": {},
"aws_cognito_login_mechanisms": [],
"aws_cognito_signup_attributes": [
"EMAIL"
],
"aws_cognito_mfa_configuration": "OFF",
"aws_cognito_mfa_types": [
"SMS"
],
"aws_cognito_password_protection_settings": {
"passwordPolicyMinLength": 8,
"passwordPolicyCharacters": []
}
};
export default awsmobile; Is This what's in my {
"identityPoolName": "authwithusernamenoat3aaa0954_identitypool_3aaa0954",
"allowUnauthenticatedIdentities": false,
"resourceNameTruncated": "authwi3aaa0954",
"userPoolName": "authwithusernamenoat3aaa0954_userpool_3aaa0954",
"autoVerifiedAttributes": [
"email"
],
"mfaConfiguration": "OFF",
"mfaTypes": [
"SMS Text Message"
],
"smsAuthenticationMessage": "Your authentication code is {####}",
"smsVerificationMessage": "Your verification code is {####}",
"emailVerificationSubject": "Your verification code",
"emailVerificationMessage": "Your verification code is {####}",
"defaultPasswordPolicy": false,
"passwordPolicyMinLength": 8,
"passwordPolicyCharacters": [],
"requiredAttributes": [
"email"
],
"userpoolClientGenerateSecret": false,
"userpoolClientRefreshTokenValidity": 30,
"userpoolClientWriteAttributes": [
"email"
],
"userpoolClientReadAttributes": [
"email"
],
"userpoolClientLambdaRole": "authwi3aaa0954_userpoolclient_lambda_role",
"userpoolClientSetAttributes": false,
"sharedId": "3aaa0954",
"resourceName": "authwithusernamenoat3aaa0954",
"authSelections": "identityPoolAndUserPool",
"authRoleArn": {
"Fn::GetAtt": [
"AuthRole",
"Arn"
]
},
"unauthRoleArn": {
"Fn::GetAtt": [
"UnauthRole",
"Arn"
]
},
"useDefault": "default",
"userPoolGroupList": [],
"serviceName": "Cognito",
"usernameCaseSensitive": false,
"dependsOn": []
} I don't see a |
...es/amplify-category-auth/src/provider-utils/awscloudformation/utils/amplify-meta-updaters.ts
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ericclemmons asked me to take a look at the PR so even if it is a draft I reviewed it to give some directions for the future changes.
...es/amplify-category-auth/src/provider-utils/awscloudformation/utils/amplify-meta-updaters.ts
Outdated
Show resolved
Hide resolved
...es/amplify-category-auth/src/provider-utils/awscloudformation/utils/amplify-meta-updaters.ts
Outdated
Show resolved
Hide resolved
...es/amplify-category-auth/src/provider-utils/awscloudformation/utils/amplify-meta-updaters.ts
Outdated
Show resolved
Hide resolved
packages/amplify-cli/src/extensions/amplify-helpers/on-category-outputs-change.ts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it possible to add a test for this?
...es/amplify-category-auth/src/provider-utils/awscloudformation/utils/amplify-meta-updaters.ts
Outdated
Show resolved
Hide resolved
...es/amplify-category-auth/src/provider-utils/awscloudformation/utils/amplify-meta-updaters.ts
Outdated
Show resolved
Hide resolved
...es/amplify-category-auth/src/provider-utils/awscloudformation/utils/amplify-meta-updaters.ts
Outdated
Show resolved
Hide resolved
...es/amplify-category-auth/src/provider-utils/awscloudformation/utils/amplify-meta-updaters.ts
Outdated
Show resolved
Hide resolved
...es/amplify-category-auth/src/provider-utils/awscloudformation/utils/amplify-meta-updaters.ts
Outdated
Show resolved
Hide resolved
packages/amplify-cli/src/extensions/amplify-helpers/on-category-outputs-change.ts
Outdated
Show resolved
Hide resolved
packages/amplify-cli/src/extensions/amplify-helpers/on-category-outputs-change.ts
Outdated
Show resolved
Hide resolved
packages/amplify-cli/src/extensions/amplify-helpers/on-category-outputs-change.ts
Outdated
Show resolved
Hide resolved
packages/amplify-cli/src/extensions/amplify-helpers/on-category-outputs-change.ts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree with @cjihrig's comments, please fix those before merging.
Regarding the awsexports (and others) generation make sure we have a test that preserves the custom values if they were present and also have a test for removal, when someone removes auth and such, then the configured values MUST be removed from awsexports (and others)
… to frontend config (aws-amplify#8037) (aws-amplify#8093)" This reverts commit b8949b2.
👋 Hi, this pull request was referenced in the v5.6.0 release! Check out the release notes here https://github.com/aws-amplify/amplify-cli/releases/tag/v5.6.0. |
… to frontend config (aws-amplify#8037) (aws-amplify#8093)" (aws-amplify#8158) This reverts commit b8949b2.
Description of changes
Description of how you validated changes
yarn test
passes,Checklist
yarn test
passesBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.