Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dispatch failure event for pwd completion error #694

Merged
merged 4 commits into from
Apr 20, 2018

Conversation

joostfarla
Copy link
Contributor

Issue #, if available:
None

Description of changes:
When an error occurs while completing the user's password, no event is dispatched. I've added this event to make it consistent with signIn/signUp to be able to implement a custom UI with proper error feedback.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@codecov-io
Copy link

codecov-io commented Apr 19, 2018

Codecov Report

Merging #694 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #694      +/-   ##
==========================================
+ Coverage   87.28%   87.28%   +<.01%     
==========================================
  Files          72       72              
  Lines        3428     3429       +1     
  Branches      652      652              
==========================================
+ Hits         2992     2993       +1     
  Misses        419      419              
  Partials       17       17
Impacted Files Coverage Δ
packages/aws-amplify/src/Auth/Auth.ts 88.09% <100%> (+0.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 652c2ab...308af82. Read the comment docs.

@mlabieniec mlabieniec requested a review from richardzcode April 19, 2018 20:31
@mlabieniec mlabieniec added the Auth Related to Auth components/category label Apr 19, 2018
Copy link
Contributor

@richardzcode richardzcode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@github-actions
Copy link

This pull request has been automatically locked since there hasn't been any recent activity after it was closed. Please open a new issue for related bugs.

Looking for a help forum? We recommend joining the Amplify Community Discord server *-help channels or Discussions for those types of questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 12, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Auth Related to Auth components/category
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants