-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dispatch failure event for pwd completion error #694
Conversation
Codecov Report
@@ Coverage Diff @@
## master #694 +/- ##
==========================================
+ Coverage 87.28% 87.28% +<.01%
==========================================
Files 72 72
Lines 3428 3429 +1
Branches 652 652
==========================================
+ Hits 2992 2993 +1
Misses 419 419
Partials 17 17
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
This pull request has been automatically locked since there hasn't been any recent activity after it was closed. Please open a new issue for related bugs. Looking for a help forum? We recommend joining the Amplify Community Discord server |
Issue #, if available:
None
Description of changes:
When an error occurs while completing the user's password, no event is dispatched. I've added this event to make it consistent with signIn/signUp to be able to implement a custom UI with proper error feedback.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.