Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

XCode 12 Build - amazon-cognito-identity-js #7747

Closed
johnny-minty opened this issue Feb 15, 2021 · 7 comments
Closed

XCode 12 Build - amazon-cognito-identity-js #7747

johnny-minty opened this issue Feb 15, 2021 · 7 comments
Labels
amazon-cognito-identity-js Used for issues related to this specific package within the monorepo React Native React Native related issue

Comments

@johnny-minty
Copy link

Problem Description:

amazon-cognito-identity-js pod spec lists 'React' instead of 'React-Core' which breaks when building under XCode 12.

Version affected:
4.5.10

See below - commentary and discussion from the react-native GITHUB:

facebook/react-native#29633 (comment)

Example pull request from a like project:

react-native-masked-view/masked-view@f218a83

@johnny-minty johnny-minty added the to-be-reproduced Used in order for Amplify to reproduce said issue label Feb 15, 2021
@amhinson
Copy link
Contributor

I've been working with RN projects that have amazon-cognito-identity-js as a dependency in Xcode 12, but I haven't come across an error before. Do you happen to have some reproduction steps?

@amhinson amhinson added amazon-cognito-identity-js Used for issues related to this specific package within the monorepo React Native React Native related issue pending-close-response-required and removed to-be-reproduced Used in order for Amplify to reproduce said issue labels Feb 15, 2021
@johnny-minty
Copy link
Author

@amhinson Thanks for the quick response. I will review this today and get back to you with reproduction steps. The problem tends to arise only when using 'use_frameworks' in the Pod file.

@johnny-minty
Copy link
Author

@amhinson I've confirmed this only occurs when building with 'use_frameworks!' in the PodFile using XCode12.

Removing it or updating the podspec for the Cognito project to depend on 'React-Core' will resolve the issue.

Steps to reproduce:

  1. react-native init amptest

  2. Add the following dependencies to package.json and run 'npm install'

    "@aws-amplify/api": "3.2.21",
    "@aws-amplify/auth": "3.4.21",
    "@aws-amplify/core": "3.8.13",
    "amazon-cognito-identity-js": "4.5.10",

  3. Open the POD file add 'use_frameworks!' to the top of the file

image

  1. Run pod install in the IOS directory
  2. Build from XCode - error occurs:

image

@amhinson
Copy link
Contributor

amhinson commented Mar 3, 2021

Thanks for looking further into that @johnny-minty 🙏 We're got a PR to address this, and should be able to get it into the next release after it is approved.

@johnny-minty
Copy link
Author

Cheers @amhinson - thanks for the quick response!

@amhinson
Copy link
Contributor

amhinson commented Mar 9, 2021

Closing this issue, as the related PR has been merged. We will likely have a new release out later this week or early next week 👍

@amhinson amhinson closed this as completed Mar 9, 2021
@github-actions
Copy link

This issue has been automatically locked since there hasn't been any recent activity after it was closed. Please open a new issue for related bugs.

Looking for a help forum? We recommend joining the Amplify Community Discord server *-help channels or Discussions for those types of questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 10, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
amazon-cognito-identity-js Used for issues related to this specific package within the monorepo React Native React Native related issue
Projects
None yet
Development

No branches or pull requests

2 participants