-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
XCode 12 Build - amazon-cognito-identity-js #7747
Comments
I've been working with RN projects that have |
@amhinson Thanks for the quick response. I will review this today and get back to you with reproduction steps. The problem tends to arise only when using 'use_frameworks' in the Pod file. |
@amhinson I've confirmed this only occurs when building with 'use_frameworks!' in the PodFile using XCode12. Removing it or updating the podspec for the Cognito project to depend on 'React-Core' will resolve the issue. Steps to reproduce:
|
Thanks for looking further into that @johnny-minty 🙏 We're got a PR to address this, and should be able to get it into the next release after it is approved. |
Cheers @amhinson - thanks for the quick response! |
Closing this issue, as the related PR has been merged. We will likely have a new release out later this week or early next week 👍 |
This issue has been automatically locked since there hasn't been any recent activity after it was closed. Please open a new issue for related bugs. Looking for a help forum? We recommend joining the Amplify Community Discord server |
Problem Description:
amazon-cognito-identity-js pod spec lists 'React' instead of 'React-Core' which breaks when building under XCode 12.
Version affected:
4.5.10
See below - commentary and discussion from the react-native GITHUB:
facebook/react-native#29633 (comment)
Example pull request from a like project:
react-native-masked-view/masked-view@f218a83
The text was updated successfully, but these errors were encountered: