fix(@amplify-js/amplify-ui-components): update required attributes given name placeholder #7961
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #7961 +/- ##
=======================================
Coverage 74.25% 74.25%
=======================================
Files 215 215
Lines 13473 13473
Branches 2646 2646
=======================================
Hits 10004 10004
Misses 3271 3271
Partials 198 198 Continue to review full report at Codecov.
|
wlee221
approved these changes
Mar 23, 2021
|
This pull request has been automatically locked since there hasn't been any recent activity after it was closed. Please open a new issue for related bugs. Looking for a help forum? We recommend joining the Amplify Community Discord server |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
The same translation string
GIVEN_NAME_LABELwas used for both the label and the placeholder of thegiven_namerequired attribute. I just updated the placeholder to use the correctGIVEN_NAME_PLACEHOLDERstring.Issue #, if available
#7959
Description of how you validated changes
Checklist
yarn testpassesBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.