-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: add subs-disabled test #7988
Conversation
94e4a9f
to
c6adb5e
Compare
Codecov Report
@@ Coverage Diff @@
## main #7988 +/- ##
=======================================
Coverage 74.24% 74.24%
=======================================
Files 215 215
Lines 13474 13474
Branches 2647 2647
=======================================
Hits 10004 10004
Misses 3272 3272
Partials 198 198 Continue to review full report at Codecov.
|
.circleci/config.yml
Outdated
steps: | ||
- prepare_test_env | ||
- integ_test_js: | ||
test_name: 'React DataStore' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This doesnt mash up with anything else we have for React?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's just a display name / label for the job that shows up in the CCI UI, but might as well call it the same thing as the test itself. Updated
c6adb5e
to
765e83d
Compare
steps: | ||
- prepare_test_env | ||
- integ_test_js: | ||
test_name: 'DataStore - Subs Disabled' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🥇
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🌮
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
This pull request has been automatically locked since there hasn't been any recent activity after it was closed. Please open a new issue for related bugs. Looking for a help forum? We recommend joining the Amplify Community Discord server |
Adding e2e test for DataStore working with disabled subscriptions to the pipeline
Successful run here: https://app.circleci.com/pipelines/github/aws-amplify/amplify-js/7443/workflows/b62d22a8-1a77-428f-ae1a-b9b7c5415846
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.