Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: add subs-disabled test #7988

Merged
merged 2 commits into from
Mar 24, 2021
Merged

ci: add subs-disabled test #7988

merged 2 commits into from
Mar 24, 2021

Conversation

iartemiev
Copy link
Member

Adding e2e test for DataStore working with disabled subscriptions to the pipeline

Successful run here: https://app.circleci.com/pipelines/github/aws-amplify/amplify-js/7443/workflows/b62d22a8-1a77-428f-ae1a-b9b7c5415846

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@iartemiev iartemiev force-pushed the add-subs-disabled-test branch 2 times, most recently from 94e4a9f to c6adb5e Compare March 24, 2021 22:08
@codecov
Copy link

codecov bot commented Mar 24, 2021

Codecov Report

Merging #7988 (765e83d) into main (0e8968f) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #7988   +/-   ##
=======================================
  Coverage   74.24%   74.24%           
=======================================
  Files         215      215           
  Lines       13474    13474           
  Branches     2647     2647           
=======================================
  Hits        10004    10004           
  Misses       3272     3272           
  Partials      198      198           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0e8968f...765e83d. Read the comment docs.

steps:
- prepare_test_env
- integ_test_js:
test_name: 'React DataStore'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesnt mash up with anything else we have for React?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's just a display name / label for the job that shows up in the CCI UI, but might as well call it the same thing as the test itself. Updated

@iartemiev iartemiev force-pushed the add-subs-disabled-test branch from c6adb5e to 765e83d Compare March 24, 2021 22:30
steps:
- prepare_test_env
- integ_test_js:
test_name: 'DataStore - Subs Disabled'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥇

Copy link
Contributor

@sammartinez sammartinez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🌮

Copy link
Contributor

@wlee221 wlee221 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@github-actions
Copy link

This pull request has been automatically locked since there hasn't been any recent activity after it was closed. Please open a new issue for related bugs.

Looking for a help forum? We recommend joining the Amplify Community Discord server *-help channels or Discussions for those types of questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 25, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants