Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(all): Enable TLSv1.2 support for older devices #3258

Merged
merged 15 commits into from
May 9, 2023

Conversation

tylerjroach
Copy link
Member

Issue #, if available:

Description of changes:

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@tylerjroach tylerjroach marked this pull request as ready for review April 25, 2023 14:35
@tylerjroach tylerjroach requested a review from a team as a code owner April 25, 2023 14:35
@tylerjroach tylerjroach merged commit 04db63d into main May 9, 2023
@tylerjroach tylerjroach deleted the tjroach/tls-upgrade branch May 9, 2023 16:33
@kaveet
Copy link

kaveet commented May 23, 2023

Hi @tylerjroach, would you mind defining "older devices" here? I have some clients on aws-android-sdk-s3:2.34.0 and SDK 21 and 22 that are already making requests over TLS1.2, so I'm a bit confused seeing this change and the specifics around SDK 21.

@tylerjroach
Copy link
Member Author

@kaveet Android 21+ Should already support TLS1.2. The changes made were for Android <= 20 which do not enable TLS 1.2 by default.

@kaveet
Copy link

kaveet commented May 23, 2023

@tylerjroach thank you for the context! That's what we're observing too. Have a great one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants