Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add submitEvent API with callbacks #2934

Merged
merged 1 commit into from
Jun 23, 2022
Merged

feat: Add submitEvent API with callbacks #2934

merged 1 commit into from
Jun 23, 2022

Conversation

sdhuka
Copy link
Contributor

@sdhuka sdhuka commented Jun 22, 2022

Issue #, if available:

Description of changes:

  • Add submitEvents API with callbacks to return successfully synced events.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@sdhuka sdhuka requested a review from a team as a code owner June 22, 2022 14:05
@sdhuka sdhuka mentioned this pull request Jun 22, 2022
Merged
1 task
@sdhuka sdhuka requested a review from tjleing June 22, 2022 14:14
div5yesh
div5yesh approved these changes Jun 22, 2022
View reviewed changes
Copy link
Contributor

@div5yesh div5yesh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sdhuka sdhuka merged commit 2049946 into main Jun 23, 2022
@sdhuka sdhuka deleted the sdhuka/pinpoint-hubevents branch June 23, 2022 01:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@div5yesh div5yesh div5yesh approved these changes

@tjleing tjleing tjleing approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sdhuka @tjleing @div5yesh